SSL Checks (Bug In Scheme Detection)

wpsharks / html-compressor

HTML Compressor. Combines and compresses CSS/JS/HTML code.

https://websharks.github.io/html-compressor/

GNU General Public License v3.0

38 stars 9 forks source link

SSL Checks (Bug In Scheme Detection) #61

Closed jaswrks closed 9 years ago

jaswrks commented 9 years ago

We should probably update this line of code to force a specific data type. At present, this is assuming SERVER_PORT will be a string, but if a server is setting the value to an integer it might be causing some trouble. https://github.com/websharks/html-compressor/blob/150512/src/includes/classes/Core.php#L2861

A similar issue here. This could also look for a boolean-ish true value. https://github.com/websharks/html-compressor/blob/150512/src/includes/classes/Core.php#L2866 e.g., if(filter_var($_SERVER['HTTPS'], FILTER_VALIDATE_BOOLEAN))

raamdev commented 9 years ago

Referencing internal ticket that led to this issue: https://websharks.zendesk.com/agent/tickets/7319

jaswrks commented 9 years ago

Done. Coming in the next release.

raamdev commented 9 years ago

Woohoo!

raamdev commented 9 years ago

@jaswsinc I noticed there was no changelog entry for this issue here: https://github.com/websharks/html-compressor/releases

jaswrks commented 9 years ago

Next Release Changelog:

Bug Fix: Improved strict data type comparison when analyzing $_SERVER environment variables to detect an https:// connection URL. We now detect (integer)443 and (string)443. In addition, we can now pick up $_SERVER['HTTPS'] being any of 1|on|yes|true (caSe insensitive).

raamdev commented 9 years ago

ZenCache Pro v150821 has been released and includes changes from this GitHub Issue.

See the ZenCache Pro v150821 announcement for further details.

This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#61).