search

wpsharks / phings

Just a few Phings we like to use :-)
GNU General Public License v3.0
1 stars 0 forks source link

phing release creates public GitHub Pro release #157

Open raamdev opened 7 years ago

raamdev commented 7 years ago

While publishing s2Member Pro v170221 today (using Phings v170105.65238), I noticed that it published a public GitHub release with the zip file attached; it shouldn't be doing that for the Pro version. The Pro GitHub release should be saved as a Draft.

2017-02-20_19-46-52

I just used Phings v170105.65238 to publish a Comet Cache release and the Pro GitHub release was not published as public... so I have no idea why it got published as public for s2Member Pro.

jaswrks commented 7 years ago

This happens because unfortunately, s2Member doesn't have a namespace that the Phing system can use to detect the pro status. In the eyes of our Phing system, s2Member Pro is not a pro version of our software like so many of our other packages are.

I'm not seeing an easy way around this at the moment, mostly because forcing it into a pro status in the eyes of our Phing system comes with some other things I'll need to review carefully.

For now, the easiest way around this problem is to add the draft flag.

$ phing release -D draft=true
raamdev commented 7 years ago

@jaswrks Cool, that will suffice for me. Thanks! I'm going to keep track of that modified step in this new s2Member Release Process template that I'm working on: https://github.com/websharks/s2member.com/wiki/Release-Process-Template

Feel free to close this GitHub issue if you don't see any further reason to keep it around.