wpsharks / s2clean

s2Clean is a premium product. This public repo is for issue tracking only.
Other
1 stars 0 forks source link

Reorganize/Refactor Codebase #14

Open jaswrks opened 9 years ago

jaswrks commented 9 years ago

@BruceCaldwell I suggest taking all of the SPCM-related methods and moving these into their own class, in an effort to reduce clutter in the functions.php file and keep things better organized.

I'd move these methods into their own class.


I'd also move this method into its own class.


I'd also move this method into its own class.


I'd also move these methods into their own class.

i.e. all of the methods prefixed with kses_.


Along with this initial work to reorganize (because there is more work to do after these), it would be great to add an autoloader to the s2Clean codebase too, so as to avoid lots of include() or require() calls, and lower the memory footprint that s2Clean has.

jaswrks commented 9 years ago

This doesn't need to be given a high priority; i.e. it's not required for the software to be launched. In fact, I'd say that we should probably not make a bunch of changes to the software before an initial launch, because that would just add extra work. The s2Clean theme has already been given considerable testing through it's application on our own sites.

brucewrks commented 9 years ago

Alongside these changes, I want to make a distinction between class files and template files, by moving class files into s2clean/classes, moving templates to s2clean/templates and leaving utilities/random functions and hooks in s2clean/includes.

This will make things easier to manage for me, and clearer for anyone that wants to come in and change any of the template files.

jaswrks commented 9 years ago

Alongside these changes, I want to make a distinction between class files and template files, by moving class files into s2clean/classes, moving templates to s2clean/templates and leaving utilities/random functions and hooks in s2clean/includes.

Sounds great to me!