Open raamdev opened 9 years ago
@jaswsinc I could use some brainstorming help here. Will having a server configured with mod_cloudflare
(so that visitors' IP addresses are passed through to the web server) be a requirement to using s2Member + CloudFlare? Are there any other issues you can think of?
I'm bumping Cloudflare testing up on my list so that I can answer this.
@raamdev writes...
Using CloudFlare results in all requests to s2Member looking like they're coming from the same IP address. What kinds of areas will this affect?
If you're running the Cloudflare WordPress plugin this should not be an issue, based on this code that I find the WordPress plugin for Cloudflare.
@raamdev writes...
I could use some brainstorming help here. Will having a server configured with mod_cloudflare (so that visitors' IP addresses are passed through to the web server) be a requirement to using s2Member + CloudFlare? Are there any other issues you can think of?
Based on the code that I just reviewed, I don't think mod_cloudflare
will be necessary if we implement checks for $_SERVER["HTTP_CF_CONNECTING_IP"]
in both s2Member and in ZenCache.
Referencing: https://github.com/websharks/zencache/issues/418
Based on the code that I just reviewed, I don't think mod_cloudflare will be necessary if we implement checks for $_SERVER["HTTP_CF_CONNECTING_IP"] in both s2Member and in ZenCache.
Awesome. That simplifies things!
I've added some of these notes to the related ZenCache issue.
I also opened an s2Member GitHub Issue to track this: https://github.com/websharks/s2member/issues/526
@raamdev writes...
I also opened an s2Member GitHub Issue to track this: websharks/s2member#526
Cool, thanks.
I am getting issues with Cloudflare whilst using the S2member pro login widget. Even though I am logged in it still has the logged out version of the widget on my pages. Nothing in browser consoles and no rules are being triggered by Cloudflare WAF. I suspect CloudFlare Rocket Loader is the culprit. Can you stick this in the plugin please to disable rocket loader specifically for the widget?
@garycarlyle Thank you for that suggestion. I agree. However, I also think we should try to avoid this altogether by having s2Member add that attribute to exclude itself. I'm opening an issue here: https://github.com/websharks/s2member/issues/1038
KB Article Creation Checklist
draft
and eitherquestions
ortutorials
draft
label, adddraft-finalized
label)draft-finalized
label, addpending
)pending
label, addpublished
label)Additional TODOs
Additional TODO list items go here.
Using CloudFlare results in all requests to s2Member looking like they're coming from the same IP address. What kinds of areas will this affect?
Have you configured your server with
mod_cloudflare
so that your visitor's IP Addresses are passed through to the web server? Please see https://www.cloudflare.com/resources-downloads#mod_cloudflare