wpsharks / s2member

s2Member® Framework (membership management for WordPress®).
64 stars 36 forks source link

JWPlayer 7 Skin Customization Broken #1060

Open renzms opened 7 years ago

renzms commented 7 years ago

EXPLANATION OF THE ISSUE

In the current version of JW Player, v7, the way skins are called and customised has now changed. Please see this article

Compared to JW6's XML model, JW Player 7 CSS-based skins. Due to this change, skin modifications can be easily made on-the-fly. See our skin-swapping example below for more information. Note that due to the fundamental changes in our skinning model, JW6 skins are not compatible with JW7.

The documentation here, is now outdated as player_skin="/jwplayer/my-skin.xml" no longer works.

STEPS TO REPRODUCE THE ISSUE

Tested Using:

WordPress Version: 4.7.2 Current WordPress Theme: Twenty Seventeen version 1.1 Active Plugins: Version 170221 + s2Member Pro v170221 PHP Version: 7.0.10 MySQL Version: 10.0.29-MariaDB-0ubuntu0.16.04.1 Apache Version: Apache/2.4.10 (Debian) JWPlayer 7

Posted shortcode as normal and added player_skin="/jwplayer/skins/vapor.css" to try and change the skin. The player skin does not change.

BEHAVIOR THAT I EXPECTED

Skin should change as noted in https://support.jwplayer.com/customer/portal/articles/1406968-using-jw-player-skins

Example using Vapor skin

screen shot 2017-03-03 at 8 58 17 pm

BEHAVIOR THAT I OBSERVED

Code used:


[s2Stream player="jwplayer-v7-rtmp-only" player_path="/jwplayer/jwplayer.js" player_key="**********" file_download="/renz/s2stream.mp4" player_skin="/jwplayer/skins/vapor.css" download_key="universal"/]

screen shot 2017-03-03 at 8 56 15 pm

Skin remains as the JW Player 7 default skin.


Referencing Internal Ticket

jaswrks commented 7 years ago

Note: the KB article at s2Member regarding JW Player v7 has been updated to include instructions and examples of how to use a custom skin in JW Player v7 via the [s2Stream /] shortcode.

Example

Instead of:

player_skin="/jwplayer/skins/vapor.css"

Use this in JW Player v7:

player_option_blocks="skin:{name:'vapor'}"