Dashicons icon gets overridden on login screen

[Beee4life]

EXPLANATION OF THE ISSUE

Dashicons font is overridden on the login page because of an !important, in inline css, generated by user settings and thus shown as a tofu.

STEPS TO REPRODUCE THE ISSUE

Install the plugin. Go to General Options > Login/Registration design. Save it. Check login screen.

BEHAVIOR THAT I EXPECTED

That the 'eye' dashicon would show in the right side of the password field.

BEHAVIOR THAT I OBSERVED

It gets overridden.

PROPOSED SOLUTION

Remove the important $i from line 110 in src/includes/classes/login-customizations.inc.php

NOTE

This only happens after saving the user settings. If not saved, default settings are used, which do not have this (css) line.

[Beee4life]

I just found out this value can be changed with a filter, see info here.

add_filter('ws_plugin__s2member_login_header_styles_important', '__return_null');

[clavaque]

I added a new rule in s2 to give importance to the dashicons font. https://github.com/wpsharks/s2member/commit/c53be4d05d713a1ce2ba66f621fc9c190d99a11c

This seems to be an issue that almost everyone will have, so I wanted to avoid it without needing a customization.