search

wpsharks / s2member

s2Member® Framework (membership management for WordPress®).
64 stars 36 forks source link

Fatal error in pro files after update! #1225

Open gaborkukucska opened 2 years ago

gaborkukucska commented 2 years ago

syscon.inc.php on line 137 has ; and " in the sprintf section.

PHP Fatal error: Uncaught ValueError: Unknown format specifier ";" in /wp-content/plugins/s2member-pro/src/includes/syscon.inc.php:137

gaborkukucska commented 2 years ago

Actually, there were many errors in the newest version but when I rolled back to 210526 that has the above error.

bridgeport commented 2 years ago

I believe this is a PHP8 incompatibility problem that affects the current and prior versions. The following link elaborates and suggests a fix by commenting out the problematic line (assuming you don't use clickbank) within the file you referenced: https://forums.wpsharks.com/t/s2member-pro-breaking-website-with-php-8/8777/21

If you don't want to edit the plugin's files, you can roll back to PHP 7.4 or below.

gaborkukucska commented 2 years ago

I believe this is a PHP8 incompatibility problem that affects the current and prior versions. The following link elaborates and suggests a fix by commenting out the problematic line (assuming you don't use clickbank) within the file you referenced: https://forums.wpsharks.com/t/s2member-pro-breaking-website-with-php-8/8777/21

If you don't want to edit the plugin's files, you can roll back to PHP 7.4 or below.

Thanks for your response! That is exactly what I did. Commented it out. We like our PHP8 :)

jason-weiser commented 2 years ago

I had this same issue and the duct tape fix that was commenting out a line of code worked for me. This is the second or third time this has happened in the past year.

Seeing as PHP 7.4 is no longer actively supported and is set to reach EOL by November, would it be possible for someone from wpsharks to put in a fix for this issue? It doesn't look good for wpsharks for their users to have to ssh in to comment out a line of code for every update or else it breaks their site and it's super annoying that it only happens to the paying customers.

I get that it's a one-time fee and they already have our money so me threatening to go with a competitor would mean less than nothing, but it just seems like a bad way to run a business, especially when other people rely on your software to run their own businesses.

I appreciate the work they do and that they made it open source and I know that me paying for their product doesn't entitle me to their time or labor. Honestly S2member pro would be a steal at 3x the price. It's just very irritating to be at the end of a long day, update your site, have it break, and the find that the hacky workaround is the same thing you had to do the last time S2member pro broke it and that a fix still hasn't been implemented.

clavaque commented 2 years ago

I just noticed I had not posted here after adding the fix to the release months ago... I'm adding this reply so that someone that finds this thread through a search, knows that this has been solved since v220421.

I'm really sorry for the inconvenience it caused you before I added it to the release. I hope you haven't had an issue with PHP8 since v220421.

:)