search

wpsharks / s2member

s2Member® Framework (membership management for WordPress®).
64 stars 36 forks source link

WP_DEBUG (debug.log) notices for Authorize.Net, PayPal Express Checkout, and user deletions #195

Closed bridgeport closed 10 years ago

bridgeport commented 10 years ago

Hi. I know you've been making a concerted effort to have s2member not have any PHP notices when WP_DEBUG is active. I understand that they're minor and don't negatively impact transaction processing or overall functionality. Still, I just wanted to paste a few for your information, in case they're not on your radar.

I'm using s2member Pro v140603

Deleting a User

I think this one goes way back. I assume it doesn't come up very often as most admins probably aren't deleting accounts often. I delete test accounts to perform test transactions, and the following notice always registers.

[08-Jun-2014 23:46:45 UTC] PHP Notice:  Undefined offset: 1 in /home/userdir/public_html/wp-content/plugins/s2member/includes/classes/user-deletions.inc.php(139) : regexp code on line 1

PayPal Express Checkout (non-subscription transaction)

[09-Jun-2014 21:06:55 UTC] PHP Notice:  Undefined offset: 2 in /home/userdir/public_html/wp-content/plugins/s2member/includes/classes/paypal-notify-in-subscr-or-wa-w-level.inc.php on line 59
[09-Jun-2014 21:06:55 UTC] PHP Notice:  Undefined index: period1 in /home/userdir/public_html/wp-content/plugins/s2member/includes/classes/paypal-notify-in-subscr-or-wa-w-level.inc.php on line 64
[09-Jun-2014 21:06:55 UTC] PHP Notice:  Undefined index: mc_amount1 in /home/userdir/public_html/wp-content/plugins/s2member/includes/classes/paypal-notify-in-subscr-or-wa-w-level.inc.php on line 65
[09-Jun-2014 21:06:55 UTC] PHP Notice:  Undefined index: recurring in /home/userdir/public_html/wp-content/plugins/s2member/includes/classes/paypal-notify-in-subscr-or-wa-w-level.inc.php on line 76
[09-Jun-2014 21:06:56 UTC] PHP Notice:  Undefined variable: user_id in /home/userdir/public_html/wp-content/plugins/s2member/includes/classes/paypal-notify-in-subscr-or-wa-w-level.inc.php on line 556
[09-Jun-2014 21:06:56 UTC] PHP Notice:  Undefined variable: modifying in /home/userdir/public_html/wp-content/plugins/s2member/includes/classes/paypal-notify-in-subscr-or-wa-w-level.inc.php on line 568
[09-Jun-2014 21:06:56 UTC] PHP Notice:  Undefined variable: modifying in /home/userdir/public_html/wp-content/plugins/s2member/includes/classes/paypal-notify-in-subscr-or-wa-w-level.inc.php on line 589

Authorize.Net (non-subscription transaction)

The last seven (out of eight) notices below are the same as the seven PayPal ones above. The only difference is the additional 'HTTP_USER_AGENT' notice at the top.

[09-Jun-2014 22:55:19 UTC] PHP Notice:  Undefined index: HTTP_USER_AGENT in /home/userdir/public_html/wp-content/plugins/s2member-pro/includes/classes/gateways/authnet/authnet-notify-in.inc.php on line 149
[09-Jun-2014 22:55:20 UTC] PHP Notice:  Undefined offset: 2 in /home/userdir/public_html/wp-content/plugins/s2member/includes/classes/paypal-notify-in-subscr-or-wa-w-level.inc.php on line 59
[09-Jun-2014 22:55:20 UTC] PHP Notice:  Undefined index: period1 in /home/userdir/public_html/wp-content/plugins/s2member/includes/classes/paypal-notify-in-subscr-or-wa-w-level.inc.php on line 64
[09-Jun-2014 22:55:20 UTC] PHP Notice:  Undefined index: mc_amount1 in /home/userdir/public_html/wp-content/plugins/s2member/includes/classes/paypal-notify-in-subscr-or-wa-w-level.inc.php on line 65
[09-Jun-2014 22:55:20 UTC] PHP Notice:  Undefined index: recurring in /home/userdir/public_html/wp-content/plugins/s2member/includes/classes/paypal-notify-in-subscr-or-wa-w-level.inc.php on line 76
[09-Jun-2014 22:55:24 UTC] PHP Notice:  Undefined variable: user_id in /home/userdir/public_html/wp-content/plugins/s2member/includes/classes/paypal-notify-in-subscr-or-wa-w-level.inc.php on line 556
[09-Jun-2014 22:55:24 UTC] PHP Notice:  Undefined variable: modifying in /home/userdir/public_html/wp-content/plugins/s2member/includes/classes/paypal-notify-in-subscr-or-wa-w-level.inc.php on line 568
[09-Jun-2014 22:55:24 UTC] PHP Notice:  Undefined variable: modifying in /home/userdir/public_html/wp-content/plugins/s2member/includes/classes/paypal-notify-in-subscr-or-wa-w-level.inc.php on line 589
jaswrks commented 10 years ago

Awesome, thanks for bringing my attention to these. We'll get those resolved soon.

jaswrks commented 10 years ago

Moving this to "Next Release" Milestone.

jaswrks commented 10 years ago

Resolved in the dev branch. Coming in the next release. Thanks again! :-)