wpsharks / wp-kb-articles

KB Articles for WordPress; adds a new Custom Post Type.
http://wpkbarticles.com/
2 stars 1 forks source link

Non-GitHub-Integrated KB Articles still show GitHub Integration-related links on frontend #100

Closed raamdev closed 9 years ago

raamdev commented 9 years ago

When a KB Article is created inside WordPress (instead of using the GitHub Integration to create a GitHub issue and Markdown file), the KB Article still shows the links to "improve this article" (links to the associated GitHub Issue) and the "[edit]" link (which links to the associated Markdown file).

However, when a KB Article is created inside WordPress instead of using the GitHub Integration, there is no GitHub Issue or Markdown file associated with it, so both of these links lead nowhere useful (well, at least the "edit" link leads nowhere useful; you could argue that linking to the KB Article GitHub repo /issues/ is still somewhat useful, as someone could just create a new GitHub Issue to suggest improvements, but I'd say that's not the intended behavior here).

Both of these links should be removed when a KB Article is created inside WordPress instead of through the GitHub Integration.

Example: http://s2member.com/kb-article/can-i-customize-pro-forms/

2015-03-25_22-39-00


What Actions Need To Occur Here?

jaswrks commented 9 years ago

Adding a list of actions (↑ above) that need to occur.

raamdev commented 9 years ago

Updating next action list to include the following note regarding the [edit] link: "When linking to the WordPress Dashboard instead of GitHub, the GitHub Icon should not appear."

jaswrks commented 9 years ago

Ah, thanks!

jaswrks commented 9 years ago

This has been resolved. s2Member.com and ZenCache.com updated.

raamdev commented 9 years ago

Tested and confirmed fixed. Thank you! :-)