search

wpsharks / wp-kb-articles

KB Articles for WordPress; adds a new Custom Post Type.
http://wpkbarticles.com/
2 stars 1 forks source link

Feature Request: Specify GitHub Processor Interval #52

Closed raamdev closed 9 years ago

raamdev commented 9 years ago

It would be nice to allow the site owner to configure how frequently the GitHub Processor runs.

Related: #51

jaswrks commented 9 years ago

Agreed. Marking this as ready for work.

jaswrks commented 9 years ago

I can see that this specific feature is not going to be possible, for a few reasons. The GitHub Processor needs to remain on a fixed timeframe in order for the engine to work in the most optimized way possible. Not just for sub-tree navigation, but for the limitations imposed by the GitHub API, and for rate limits also.

However, there are some important options associated with this behavior that would allow for more control over this, and those could be exposed in the UI at some point in the future. Referencing: https://github.com/websharks/wp-kb-articles-pro/blob/000000-dev/wp-kb-articles-pro/plugin.inc.php#L415

raamdev commented 9 years ago

However, there are some important options associated with this behavior that would allow for more control over this, and those could be exposed in the UI at some point in the future. Referencing: https://github.com/websharks/wp-kb-articles-pro/blob/000000-dev/wp-kb-articles-pro/plugin.inc.php#L415

I wouldn't even bother with exposing those. If anything, we could add filters so an advanced site-owner could override the defaults if they really wanted to, but I'm not seeing those as something we'd want to clutter the UI with.

I'd say we can call this issue closed. The work you did adding the GitHub Processor Button and the "Sync w/ GitHub" links on each KB Article are sufficient to provide additional control over this functionality, IMO.

@jaswsinc I'll let you close this issue if you concur. :-)

jaswrks commented 9 years ago

Agreed :-)