Closed jaswrks closed 9 years ago
Keeping both in s2Clean, sticking with Parsedown Extra for WPKBA and I'm enabling support for GitHub-style line breaks, since that is expected when using GitHub integration.
Original report above: Most of this turned out to be a false alarm. The larger issue that I was having with Parsedown turned out to be a problem with WordPress itself, and it was systemic. I'll document that as part of my work on s2Clean later.
In summary:
It's all good :smile:
I recently updated WPKBA so that is now uses the newer/lighter Parsedown Extra library instead of the PHP Markdown Extra library. I did the same in the s2Clean theme.
After some initial tests I am noticing a few subtle issues with Parsedown Extra. It seems there are a still a few kinks that need to get worked out in the Parsedown library, and in Parsedown Extra also. It's much much faster, but not doing the job yet I'm afraid.
As one quick example, bold italics are broken whenever there are underscores anywhere within either. I'm also seeing some problems with nested list parsing too. Referencing: https://github.com/erusev/parsedown/issues See also: http://parsedown.org/extra/
Considering the following changes: