wpsharks / wp-kb-articles

KB Articles for WordPress; adds a new Custom Post Type.
http://wpkbarticles.com/
2 stars 1 forks source link

Category Tabs Should Drop Tags #98

Closed jaswrks closed 9 years ago

jaswrks commented 9 years ago

@raamdev Would you agree that clicking a Tab should clear any Tag filters?

I have noticed that clicking a Tab with filters already applied often leads me to an empty set of results. When I click a Tab, I sort of expect to see everything in that category. Do you?


What Actions Needs To Occur Here?

raamdev commented 9 years ago

Would you agree that clicking a Tab should clear any Tag filters?

Yes. I have noticed this quirk too--I'm not sure why I never brought it up.

There are two ways this could be fixed:

  1. Clicking the category tab immediately clears any tag filters and search filters.
  2. Clicking the category tab shows that category, filtered by the applied tag and search (current behavior), but clicking it a second time (e.g., clicking "Tutorials" while already viewing "Tutorials") would clear the tag and search filters.

The second option is how I would expect it to work. When I discover that my filter is still applied when switching categories, my next instinct is to click the category tab again to clear the filter.

jaswrks commented 9 years ago

@raamdev writes...

but clicking it a second time (e.g., clicking "Tutorials" while already viewing "Tutorials") would clear the tag and search filters.

Ha. Interesting. It never occurred to me that clicking it a second time would do anything different; i.e., I would not expect that myself.

jaswrks commented 9 years ago

Adding a list of actions (↑ above) that need to occur.

jaswrks commented 9 years ago

This has been resolved. s2Member.com and ZenCache.com updated.

raamdev commented 9 years ago

Tested and confirmed fixed. Thank you!