wpsight / wpcasa

WPCasa WordPress Real Estate
https://wpcasa.com
GNU General Public License v2.0
42 stars 23 forks source link

[BUG] PHP 8.2 warning related to Ninja Form Addon #126

Open Jimmi08 opened 1 month ago

Jimmi08 commented 1 month ago

Prerequisites

Description

If you install Ninja Form addon, there are PHP warnings in PHP 8.2 Deprecated: Creation of dynamic property WPSight_Framework::$ninja_forms is deprecated in wp-content\plugins\wpcasa-ninja-forms\wpcasa-ninja-forms.php on line 85

This warning causes new warnings like Warning: Cannot modify header information - headers already sent by (output started at \wp-content\plugins\wpcasa-ninja-forms\wpcasa-ninja-forms.php:85) in \includes\misc.php on line 1438

Fix

Everything was fixed just by adding new property to WPSight_Framework in wpcasa.php

public $ninja_forms;

I could sent PR but I am not sure if this is correct fix.

Environment

Server & Site

codestylist commented 1 month ago

Thank you @Jimmi08 for your message. We have not noticed this issue yet and will investigate it further.