wpsmith / genesis-sandbox-featured-content-widget

Genesis Sandbox Featured Content Widget. Based on Nick Croft's Genesis Featured Widget Amplified for additional functionality which allows support for custom post types, taxonomies, and extends the flexibility of the widget via action hooks to allow the elements to be re-positioned or other elements to be added.
39 stars 21 forks source link

Taxonomy select not populated in widget #14

Closed jalberts closed 10 years ago

jalberts commented 10 years ago

It seems like there's an issue with getting taxonomies for the select box, apparently for both posts and custom post types. I suspect this was introduced in the first pass for #7 commit.

The behavior I'm seeing is that the only item in the select box is the default "All Taxonomies and Terms". I do not see any options for the actual individual taxonomies/terms. This is for both posts and CPTs. I have also verified that all of the taxonomies aren't empty (since the hard coded behavior is to hide empty).

Reverting to the current WordPress repo version (1.1.0), the problem does not exist. The problem also didn't exist in v.1.0.0 (had it running on another site and hadn't updated it yet).

My impression is that $taxonomy and/or $terms is empty for some reason, but I haven't tracked down where it's failing yet.

Anyone else seeing this behavior or have an idea on where it's falling down?

iam1980 commented 10 years ago

Hi, I'm experiencing the same issue. Unfortunately I have no Idea what is causing this. @jalberts have you made any progress with this or just reverted to 1.1.0?

WP 3.9, Genesis 2.0.2, GSFCW 1.1.4

jalberts commented 10 years ago

I'm actually still operating on a reverted v.1.0 copy. I'd kinda of forgotten about this specific problem; I'll see if I can at least narrow down the underlying cause.

iam1980 commented 10 years ago

jalberts, could you please help me find a v.1.0 copy because I havent been able to get one

jalberts commented 10 years ago

I'm not precisely sure when this error crept in, but you can try the version from directly before the commit I mentioned above (select download zip).

If that one doesn't work, you could step back commits until you find one that does. You can access these previous versions by clicking on the Commits tab, and clicking on Browse code (below the button with the commit number). That's how I got to the commit I linked above.

PatNarciso commented 10 years ago

This is an edit I made that allows me to work around this issue; until it is resolved.

widget.php:~1670

-- $taxonomies = GS_Featured_Content::get_taxonomies( apply_filters( 'gsfc_get_taxonomies_args', array( 'public' => true ), $instance, $obj ), 'objects' ); -- $taxonomies = array_filter( $taxonomies, array( CLASS, 'exclude_taxonomies' ) ); ++ #my work around to issue 14 ++ $taxonomies = get_taxonomies( array( 'public' => true ), 'objects' );

PatNarciso commented 10 years ago

Thank you Travis.