search

wpsmith / genesis-sandbox-featured-content-widget

Genesis Sandbox Featured Content Widget. Based on Nick Croft's Genesis Featured Widget Amplified for additional functionality which allows support for custom post types, taxonomies, and extends the flexibility of the widget via action hooks to allow the elements to be re-positioned or other elements to be added.
39 stars 21 forks source link

Class issues #4

Closed wpperform closed 10 years ago

wpperform commented 10 years ago

I tried the widget and it looks great. Thanks for creating this. However, it appears there are some issues with classes (#1, #3 & #4) and a couple of places where docs could clarify things.

  1. On the H2 headline for each post, your widget adds a class of entry-title to each H2, whereas GFWA does not. I don't have a strong opinion as to which is correct; I'm only pointing out the difference in case it wasn't intended. For folks using this as a replacement for GFWA, that introduces some styling changes.
  2. Similar to the above, GFWA uses classes of featured-post and featured-page and is more like the standard Genesis widgets. You use featured-content. I actually prefer your approach because it is simpler, but it's different from GFWA. Maybe a heads up for those using this as a replacement?
  3. When choosing to display a CPT of "storybank" (registered through our own custom plugin), we ended up with a class of "featuredstorybank". It seems that a dash as in "featured-storybank" would better fit the other class names you used.
  4. Adding a custom post class or a column class (used 1/2) doesn't seem to work. That is, I added them in the widget settings, but they're not in the output anywhere. Maybe they conflict with 1 of my other settings?
  5. The instance ID field got auto-updated with a slug of my widget title on save, which was nice. Perhaps the metabox help text of "You MUST set ..." could be modified to say "Instance Identification Field must be filled in, which will be auto-populated based on your widget title"

Hope that helps. Thanks again.

wpsmith commented 10 years ago

Numbers 2 and 3 I am going to leave as is. Fixing 3 will break anyone who is currently using the plugin now though you are probably right. Others fixed. Props!