search

wpsmith / genesis-sandbox-featured-content-widget

Genesis Sandbox Featured Content Widget. Based on Nick Croft's Genesis Featured Widget Amplified for additional functionality which allows support for custom post types, taxonomies, and extends the flexibility of the widget via action hooks to allow the elements to be re-positioned or other elements to be added.
39 stars 21 forks source link

Show Category Archive Link text and override not working #9

Closed handiger closed 10 years ago

handiger commented 10 years ago

Hi, Nice functionality. But Enabled Show Category Archive Link and added link text and override url. But the changed link text isn't shown and the override url isn't used.

jalberts commented 10 years ago

It's a problem with the output returned in a printf(). @jb510 has it fixed in the fork he made a few days ago. Take a look at the commit. The fix is very easy to implement yourself until @wpsmith implements it.

It doesn't look like there was a pull request made for that change either. So, I may just make a new fork and open a PR with the change.

handiger commented 10 years ago

Hi @jalberts , Thanks a lot. It's nice to have it working.

jb510 commented 10 years ago

TY both. Yes, simple fix. I didn't put in a pull request because my fork had a syntax error elsewhere I needed to fix. I'll put one in for that commit.

jb510 commented 10 years ago

Argh... well I sepereated it from my other changes (limited select taxonomy query to categories, my site no custom taxonomies but has 60,000 post tags and it was blowing trying to get tax+terms), but then I put in the pull request with a new issue number #10 and I can't recall how to change/fix it. So... it's there, enjoy :)

jalberts commented 10 years ago

Wow, that's a lot of post tags for sure. Thanks for putting the PR for that fix up :>