search

wptide / docs

Tide is an automated tool to provide insight into WordPress code and highlight areas to improve the quality of plugins and themes.
https://wptide.org/
MIT License
24 stars 14 forks source link

Yoda condition fix in url_origin() #37

Closed mukeshpanchal27 closed 4 years ago

mukeshpanchal27 commented 4 years ago

Yoda condition in /docs/functions/get-current-url.php as per https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#yoda-conditions document

mukeshpanchal27 commented 4 years ago

@jeffpaul Can you please check this?

jeffpaul commented 4 years ago

I thought, at first, that this was a change to some docpress files (in which case I was going to recommend we push the change upstream and then update when docpress releases the change). However, this code does appear to be custom when we originally built out the docs site back in the summer of 2018. I'm generally ok with these changes, but not certain what coding standard we're following for the docs site and whether WPCS fully applies here?

mukeshpanchal27 commented 4 years ago

Respected @jeffpaul,

Do I need to update the pull request? or it is your thought?