wptide / wptide.org

Tide is a WordPress.org Component that runs a series of automated tests against every WordPress.org theme and plugin
https://make.wordpress.org/tide
MIT License
7 stars 5 forks source link

Tide haults auditing when it encounters a plugin not on WP.org #130

Open bbonahoom opened 12 months ago

bbonahoom commented 12 months ago

Bug Description

PHP Compatibility Scanner v1.6.2 Scan stuck on Gravity Forms 2.7.9 after casting an error (Response status: 404 Message: The audit requested does not exist.) for Gravity Edit 2.0

Expected Behaviour

Complete scan and move on to other plugins

Steps to reproduce

  1. Start scan

Screenshots

image

Additional context


Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

Acceptance criteria

Implementation brief

QA testing instructions

Demo

jeffpaul commented 11 months ago

@bbonahoom https://wordpress.org/plugins/search/Gravity%2520Edit/ does not appear to be a valid plugin on the wp.org repo. I'm closing this as Tide only audits plugins available publicly on the wp.org repo.

bbonahoom commented 11 months ago

@jeffpaul - you missed the point of my problem. Sorry if I didn't state it clear enough. Tide didn't skip over the plugin. It. Got. Stuck. My expected behavior is that it call the scan complete and move on. Not to get stuck on plugins it doesn't recognize.

pbiron commented 8 months ago

My expected behavior is that it call the scan complete and move on. Not to get stuck on plugins it doesn't recognize.

I completely agree with the above! Not only are there premium plugins (eg. Gravity Forms), but there are also "site-specific" plugins that aren't going to be in the .org repo.

For any plugin encountered during a scan that is not in the .org repo, the PHP Compatibility Checker plugin should simply report "Plugin X is not in the .org repo and so we can't report which versions of PHP it is compatible with." and go on to the next plugin.

As is, I can no longer scan any site I work on, as they all have either premium or "site-specific" plugins (and most have both).