search

wptmdoorn / methcomp

Python package providing functionality and plotting for chemistry method comparison
MIT License
14 stars 9 forks source link

Implementation of BlandAltman comparer with new API #22

Closed wptmdoorn closed 3 years ago

wptmdoorn commented 3 years ago

This pull requests implements the BlandAltman class using the new Comparer API. It also passes all units test.

Happy to receive feedback!

codecov-commenter commented 3 years ago

Codecov Report

Merging #22 (ccfa7e6) into master (9918e07) will increase coverage by 1.03%. The diff coverage is 88.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   91.86%   92.90%   +1.03%     
==========================================
  Files          11       13       +2     
  Lines         861     1015     +154     
==========================================
+ Hits          791      943     +152     
- Misses         70       72       +2
Impacted Files Coverage Δ
methcomp/blandaltman.py 91.02% <85.71%> (-1.38%) :arrow_down:
methcomp/__init__.py 100.00% <100.00%> (ø)
methcomp/tests/test_blandaltman.py 100.00% <100.00%> (ø)
methcomp/tests/test_mountain.py 100.00% <0.00%> (ø)
methcomp/mountain.py 98.07% <0.00%> (ø)
methcomp/regressor.py 97.74% <0.00%> (+1.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9918e07...ccfa7e6. Read the comment docs.

wptmdoorn commented 3 years ago

I've revised your comments. You can accept it and merge if you are satisfied. Thanks a lot :)