search

wptmdoorn / methcomp

Python package providing functionality and plotting for chemistry method comparison
MIT License
14 stars 9 forks source link

Dev seperation api #7

Closed wptmdoorn closed 3 years ago

wptmdoorn commented 3 years ago

As discussed, very happy to receive feedback!

codecov-commenter commented 3 years ago

Codecov Report

Merging #7 (c50e5a4) into master (3666254) will increase coverage by 0.24%. The diff coverage is 89.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   89.03%   89.28%   +0.24%     
==========================================
  Files           7        7              
  Lines         821      821              
==========================================
+ Hits          731      733       +2     
+ Misses         90       88       -2
Impacted Files Coverage Δ
methcomp/glucose.py 83.70% <66.66%> (-0.20%) :arrow_down:
methcomp/blandaltman.py 92.10% <88.46%> (+2.57%) :arrow_up:
methcomp/tests/test_blandaltman.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 30bfe63...c50e5a4. Read the comment docs.

wptmdoorn commented 3 years ago

Thanks for all the feedback @thomasburgess - I revised it a second time. Would you be able to look at it one more time before we merge it?

Besides your changes, I also changed the tests (they should be passing now; we might need to include a few more to make it fully covered), and I started using 'black' as formatting tool (love it), so it should slowly become better now :)

We should probably add something pre-commit or even a pipeline in committing, but maybe this is a little bit overkill for such a (small) project :-). Thanks a lot!

thomasburgess commented 3 years ago

I can set up pre-commit once this is merged, this is easy and I can just copy my setup from one of my other projects. Agreed on pipelines, leave those for a rainy day...