search

wptrainingteam / repo-template

Template for creating lesson plan repos, including the lesson plan template. Fork this or use it as a template to create new lesson plans.
GNU General Public License v3.0
14 stars 41 forks source link

fix: remove multiple script tags from slides html #20

Closed swashata closed 5 years ago

swashata commented 5 years ago

Inside slides/index.html there were multiple script tag pointing to the same shower.min.js file. Since the repo itself doesn't contain any file on its own and the assets are served from github CDN, we can remove the reference to the local asset.

Fixes #19

JulieKuehl commented 5 years ago

@swashata what would happen if someone tried to view the slides while they were not connected to the internet then

swashata commented 5 years ago

Right now if someone tries to view offline (without the changes made here), then it would fail too. Because the file shower.min.js isn't there.

If you think having local copy is a good idea (which I think too) then I can remove the CDN and have it served locally.

But we cannot have both the script tags.

JulieKuehl commented 5 years ago

This was meant to be a fallback. The idea is that the second one would be the online source of the latest version of the Training Team's slide files, while the other one would be a local (possibly older) version. Is there a better solution?

JulieKuehl commented 5 years ago

You know what? We'll just treat this like the CSS file and see about including a copy of the CDN file in the download.

Thank you for spotting this!!!