search

wpumacay / DeeprlND-projects

Projects from the DeeprlND from Udacity
5 stars 1 forks source link

Sumtree returning min value of zero #1

Closed wpumacay closed 5 years ago

wpumacay commented 5 years ago

The current implementation of the sumtree (sumtree.py) gives a divide by zero when computing the min value, which is needed for the max wi division in the importance sampling calculation.

The np.min is computed over all nodevalues, and if the tree buffer data is just initialized with less than capacity elements, then at least one entry is zero, thus giving a divide by zero warning.

wpumacay commented 5 years ago

Potential fix: 4a8a5fa870d43549284d78d627b26d83320c2e12

Use functionality from segmentree.py instead of sumtree.py

wpumacay commented 5 years ago

Fixed by 4a8a5fa