search

wqweto / ZipArchive

A single-class pure VB6 library for zip with ASM speed
MIT License
55 stars 23 forks source link

ZIP_DEFLATE conditional compilation to mirror ZIP_INFLATE? #9

Closed tannerhelland closed 5 years ago

tannerhelland commented 5 years ago

In https://github.com/wqweto/ZipArchive/commit/2421dda691c9140e826361be903a8ae13446d48d, low-level Inflate() wrappers were made accessible to outside callers - a great idea for VB6 devs looking to drop a zlibwapi dependency.

Does it make sense to do something similar for low-level Deflate() wrappers? Your great contribution to VB6 compression tester already provides a possible implementation, as I recall.

wqweto commented 5 years ago

I've been having the same idea for some time now.

Will take care of it shortly.

wqweto commented 5 years ago

Decided to impl Deflate under ZIP_INFLATE conditional compilation in https://github.com/wqweto/ZipArchive/commit/4612740330706e7f4c86bab63d435185007ef700

Turned out w/o base64 counterpart as there is no base64 encoding routing "for free" in class already.

tannerhelland commented 5 years ago

+1 looks great, thank you!

Just sent a small PR for base64 as the symmetry of this class is lovely and I'd hate to see it ruined... ;)

Thanks as always for another very fast resolution.