search

wr0ngway / sidekiq-dynamic-queues

A sidekiq plugin for specifying the queues a worker pulls from with wildcards, negations, or dynamic look up from redis
MIT License
17 stars 22 forks source link

Does not work with latest version of Sidekiq (2.12) #1

Closed michaelmwu closed 11 years ago

michaelmwu commented 11 years ago

I've started a fork at https://github.com/Pixelapse/sidekiq-dynamic-queues to fix issues.

First issue is that there is a NameError on Celluloid on load. I've fixed that issue.

Next is that the first integration fails and the last 2 integration tests get stuck. Haven't figured out that one yet.

wr0ngway commented 11 years ago

Cool, thanks, I'll merge in what you have and see if I can figure the integration test problem - the helper I wrote for running a full sidekiq stack in the test is a little unreliable.

On Jun 12, 2013, at 11:06 PM, Michael Wu wrote:

I've started a fork at https://github.com/Pixelapse/sidekiq-dynamic-queues to fix issues.

First issue is that there is a NameError on Celluloid on load. I've fixed that issue.

Next is that the first integration fails and the last 2 integration tests get stuck. Haven't figured out that one yet.

— Reply to this email directly or view it on GitHub.

wr0ngway commented 11 years ago

Ok, merged in, fixed tests, and released 0.5.5. Thanks!

michaelmwu commented 11 years ago

Yay! The sleeps do look mildly hacky but I'm guilty of doing similar things ;)

Glad you figured out why I was autoloading Fetch after Celluloid without me saying anything