wraithan / cargo-bump

ISC License
86 stars 24 forks source link

--git-tag does not commit `Cargo.lock` #24

Open zkat opened 5 years ago

zkat commented 5 years ago

Every time I do cargo bump -g now, I get Cargo.lock as a modified file in my project root, after the commit :(

wraithan commented 5 years ago

I thought it was the next cargo build after cargo bump -g which then updates the Cargo.lock. Not the cargo bump -g itself. I can test that soon to be sure.

rubik83 commented 4 years ago

This bug is also visible in the release of cargo-bumb itself In this zip : https://github.com/wraithan/cargo-bump/archive/1.1.0.zip In Cargo.lock line 65 : version = "1.0.2" The version of cargo-bump is bad

gibfahn commented 4 years ago

I thought it was the next cargo build after cargo bump -g which then updates the Cargo.lock. Not the cargo bump -g itself. I can test that soon to be sure.

Yeah this is true, but ideally the bump commit would include the change to the Cargo.lock as well.

Stargateur commented 4 years ago

cargo bump -g should do a cargo check

LevitatingBusinessMan commented 1 year ago

I solved this in my branch by having cargo generate the lockfile