Closed eladnava closed 6 years ago
@lupomontero Hope you're doing great. Did you get a chance to look at this mate?
Hi @lupomontero, Hope you're doing great!
I see that you self-assigned this, would just like to bring to your attention that in 14 days, the breaking change takes effect and the library will fail in production for everyone.
Please let me know if you will not be able to find time to work on this so that I will submit a PR instead.
Hi @lupomontero, Hope you're doing great.
A reply from you would be greatly appreciated. There are just 8 days left until the breaking change hits production.
Even a reply mentioning that you won't be able to work on it is fine. Just let us know so that we have sufficient time to develop a fix.
Thanks, Elad
@lupomontero @eladnava I went ahead and opened https://github.com/wrangr/awis/pull/21
Tests still fail for should allow apostrophe in path when doing CategoryBrowse
. No matter how I encode, it doesn't seem to accept the Path
parameter. If any of you could lend a second pair of eyes on this test?
I'm not using that part of the API and I don't have enough free time right now to devote on this.
@Janpot looks awesome brother. Well done! ๐
Just wondering about line 137: https://github.com/wrangr/awis/pull/21/files#diff-168726dbe96b3ce427e7fedce31bb0bcR137
Is the us-west-1
region hard-coded in the API endpoints intentionally? Are there any adverse effects to doing this?
In any case, I have a feeling @lupomontero will not be around to review, merge, and publish this to npm
in time for the breaking change.
Do you want to publish a temporary package to npm with the commits you made? If not, I'll be happy to do it as well.
Is the
us-west-1
region hard-coded in the API endpoints intentionally?
Yes, aws4
uses us-east-1
as a region by default. This didn't work. The code samples provided by Amazon all used us-west-1
which worked for me.
It also looks right now that it works even without adding the policy.
right now we're importing it as
"awis": "git://github.com/Woorank/awis.git#aws-sign-v4",
We'll publish a version in a few weeks if @lupomontero stays inactive. You are free to publish a version if you don't want to import github dependencies.
@Janpot Regarding the region, sounds good.
The breaking change that your PR addresses becomes active in January 31st, in just a few days time.
I will be happy to publish your fix as a new package in the meantime if you don't mind as I would like my production app to be able to access awis
without failure after the breaking change. ๐
Awesome, just published awis-sign-v4
that includes your PR. ๐
Just tested and it works perfectly! Even with an IAM user with the awis:GET
permission:
https://docs.aws.amazon.com/AlexaWebInfoService/latest/MakingRequestsChapter.html
Cheers @Janpot ๐
When this gets merged by @lupomontero I'll go back to using awis
in production. As a reminder, the breaking change goes into effect tomorrow!
@eladnava and @Janpot: many apologies for the extended silence... ๐ข
I have been incredibly busy and had not had the time to review this until today. I finally reviewed the pending PR and merged it into master ๐
WRT the failing tests (the one about the apostrophe), I have simply skipped it for now... I spent a little while just now trying to figure it out, but can't seem to...
On a different note, would any of you guys volunteer to help maintain this repo?
I have just released a new version with the changes. Can you guys confirm whether this fixes the issue? Thanks!
Hi @lupomontero,
I can confirm the new version of awis
works. ๐
Thank you @lupomontero!
@eladnava can you note in your new module that it is deprecated then?
Absolutely: https://www.npmjs.com/package/awis-sign-v4
Hey guys, Just got this e-mail from AWS stating that root IAM account keys will no longer work for authenticating against AWIS.
AWIS will start requiring an AWIS-policy-granted IAM user instead of the root account user, but only through its Auth v4 API.
Seeing as this package does not use the Auth v4 way of authenticating against AWIS (with the
Authorization
header), this is a breaking change and AWS has only granted about 40 days for us to comply with it.An example Auth v4 request is detailed here: http://docs.aws.amazon.com/AlexaWebInfoService/latest/ApiReference_UrlInfoAction.html
The e-mail from AWS:
@lupomontero Is modifying this library to work with Auth v4 feasible? Is this something you would have time to do?