wrapp-archive / WebImage-Android

Asynchronous image loading library for Android
MIT License
41 stars 5 forks source link

Leak in AndroidHttpClient #9

Closed ghost closed 12 years ago

ghost commented 12 years ago

I am using the develop-branch and just noticed this error:

D/CZHD::Grid::WebImage(3395): Cached version of http://xxxxxxx.xxx/images/2011/xl/10141_xl.jpg found, but has expired.
D/CZHD::Grid::WebImage(3395): Requesting image 'http://xxxxxxx.xxx/images/2011/xl/10141_xl.jpg'
D/dalvikvm(3395): GC_FOR_ALLOC freed 126K, 36% free 13892K/21639K, paused 24ms
E/AndroidHttpClient(3395): Leak found
E/AndroidHttpClient(3395): java.lang.IllegalStateException: AndroidHttpClient created and never closed
E/AndroidHttpClient(3395):  at android.net.http.AndroidHttpClient.<init>(AndroidHttpClient.java:158)
E/AndroidHttpClient(3395):  at android.net.http.AndroidHttpClient.newInstance(AndroidHttpClient.java:144)
E/AndroidHttpClient(3395):  at android.net.http.AndroidHttpClient.newInstance(AndroidHttpClient.java:153)
E/AndroidHttpClient(3395):  at com.wrapp.android.webimage.ImageDownloader.getHttpClient(ImageDownloader.java:161)
E/AndroidHttpClient(3395):  at com.wrapp.android.webimage.ImageDownloader.getServerTimestamp(ImageDownloader.java:129)
E/AndroidHttpClient(3395):  at com.wrapp.android.webimage.ImageCache.loadImageFromFileCache(ImageCache.java:120)
E/AndroidHttpClient(3395):  at com.wrapp.android.webimage.ImageCache.loadImage(ImageCache.java:66)
E/AndroidHttpClient(3395):  at com.wrapp.android.webimage.ImageLoader$Worker.processRequest(ImageLoader.java:125)
E/AndroidHttpClient(3395):  at com.wrapp.android.webimage.ImageLoader$Worker.run(ImageLoader.java:71)
D/CZHD::Grid::WebImage(3395): Saved image 2fa44ae9eb3fd74a5029e71e7d3c4bec to file cache
D/CZHD::Grid::WebImage(3395): Downloaded image: http://xxxxxxx.xxx/images/2011/xl/10142_xl.jpg

I am not sure if this problem is related to Cached version of xxx found, but has expired., because I see it happening also without this.

nikreiman commented 12 years ago

Fixed in 5746943.