search

wrathematics / ngram

Fast n-Gram Tokenization
Other
71 stars 23 forks source link

Not possible to keep cases in preprocess #5

Closed jakob-r closed 6 years ago

jakob-r commented 6 years ago

According to the documentation this should work:

ngram::preprocess("Keep Case", case = NULL)

But ngram:::check.is.string does not allow NULLs.

Small tip: Instead of writing the check functions yourself you could use checkmate where it simply would be assertString(remove.punct, null.ok = TRUE)

wrathematics commented 6 years ago

Thanks, should be fixed now.

jakob-r commented 6 years ago

Thanks