wrav / SimpleSharing

MIT License
8 stars 8 forks source link

Error when updating to v1.0.7 #17

Closed supman closed 11 months ago

supman commented 3 years ago

Once our Craft3 installation finished updating to v1.0.7 our admin crashed. When reviewing CRAFT error logs we found:

The file or directory to be published does not exist: /var/www/vhosts/mydomain.com/httpdocs/vendor/wrav/simplesharing/src/assetbundles/simplesharing/dist/js/SimpleSharing.js in /var/www/vhosts/entorno.es/httpdocs/vendor/yiisoft/yii2/web/AssetManager.php:455

Our system is a CENTOS7 and this folder does not exist, the one that exists is:

/var/www/vhosts/mydomain.com/httpdocs/vendor/wrav/simplesharing/src/assetbundles/SimpleSharing/dist/js/SimpleSharing.js

We had to rename this folder manually over our filesystem to make everything work again.

But it is a manual solution and don't now yet if it breaks anything else on Simple Sharing.

lenvanessen commented 3 years ago

@reganlawton same issue here.

lenvanessen commented 3 years ago

@reganlawton only occurs on linux, on macbook (which ignores uppercase/lowercase) it doesn't occur

reganlawton commented 3 years ago

Hmm 😩 this means renaming 😂 I'll have to look at this over the weekend as I'm flat out today.

kylerits commented 3 years ago

Any update to this? I'm still seeing this error.

An Error occurred while handling another error: yii\base\InvalidArgumentException: The file or directory to be published does not exist: [...]/vendor/wrav/simplesharing/src/assetbundles/simplesharing/dist/js/SimpleSharing.js in [...]/vendor/yiisoft/yii2/web/AssetManager.php:455

reganlawton commented 3 years ago

This is still coming it requires refactoring all the files and testing I haven't been able to get to this I've been flat out all this week including the public holiday in Melbourne, AUS on Tuesday.

brandondeweese commented 3 years ago

Still seeing this error....

extensibleseth commented 3 years ago

It's a hack until v1.0.8, but I added a lowercase symlink in /vendor/wrav/simplesharing/src/assetbundles:

ln -s SimpleSharing simplesharing

reganlawton commented 3 years ago

Can anyone please give "wrav/simplesharing": "dev-alpha" a go and let me know if it's working your end. I also added a fix to PHP 7.4 support

lenvanessen commented 3 years ago

@reganlawton tested, works. However, the php version check is unneeded, see documentation of implode:

implode() can, for historical reasons, accept its parameters in either order. For consistency with explode(), however, it is deprecated not to use the documented order of arguments.

reganlawton commented 3 years ago

@lenvanessen thanks for testing notes on implode and will take another look and tweak