wrav / oembed

A simple plugin to extract media information from websites, like youtube videos, twitter statuses or blog articles.
MIT License
37 stars 36 forks source link

Additional data missing for media objects #144

Open anita-chouhan opened 9 months ago

anita-chouhan commented 9 months ago

I am using the oEmbed plugin to render media embeds. Currently, the field type methods (entry.field.media and entry.field.embed) are returning very few details for the embed object.

Example Using the below code: {% dd(entry.field.media) %}

returns only:

Screenshot 2023-11-27 at 2 27 56 PM

I need some other media details like type, provider name etc for different purposes. Can you please look into it?

Steps to reproduce

  1. Create a Craft CMS entry with an oEmbed field.
  2. In the field value set any YouTube or Vimeo URL.
  3. In the frontend template try to render media type using the below method {{ entry.field.media.type }}

Input field value YouTube Link: https://www.youtube.com/watch?v=35kwlY_RR08

Expected Output Additional media details as mentioned in the plugin doc.

entry.field.media.title
entry.field.media.description
entry.field.media.url
entry.field.media.type
entry.field.media.image
entry.field.media.imageWidth
entry.field.media.imageHeight
entry.field.media.code
entry.field.media.width
entry.field.media.height
entry.field.media.aspectRatio
entry.field.media.authorName
entry.field.media.authorUrl
entry.field.media.providerName
entry.field.media.providerUrl
entry.field.media.providerIcons
entry.field.media.providerIcon
entry.field.media.publishedDate

Additional Information PHP version: 8.0.15 Craft CMS version: 3.8.17 oEmbed version: 1.13.19

reganlawton commented 9 months ago

I'll look into this more today @anita-chouhan

reganlawton commented 9 months ago

@anita-chouhan Can I confirm your using the the release from Nov 2, 2022 AKA 1.13.19?

anita-chouhan commented 9 months ago

@reganlawton Thank you for looking into it. Yes, I'm using version 1.13.19 of the plugin.

reganlawton commented 9 months ago

@anita-chouhan I'll have to look into CraftCMS v3. My current Docker setup is for CraftCMS v4.

I'll get back too you on why on the issue, as it's been a why since I used the v1 branch, and it is 10:30pm AEST 😅

espensgr commented 6 months ago

Any news here @reganlawton? We are experiencing this on our Craft 3 site too.

reganlawton commented 6 months ago

Oh sorry this is one of the tasks that fell off my todo list 😩 I'll assign some time to this task this weekend

reganlawton commented 6 months ago

I'm still working on this I'm just having issues with building an older version as I dont hav the setup from >1yr ago

maxfenton commented 5 months ago

This is just info, but I get a lot of use out of ddev snapshot which makes saving database versions a lot easier during migrations and upgrades and makes rolling back or temporarily loading old versions a lot easier, too. https://ddev.readthedocs.io/en/latest/users/usage/database-management/#snapshots

espensgr commented 2 months ago

Any progress here?

espensgr commented 1 month ago

Tested to turn off the cache and deleted the template cache, and then it worked, so it seems it is a caching issue like in #145 . Is there a way to get this fixed @reganlawton?

reganlawton commented 4 weeks ago

A complete rework on the caching is on my pipeline still. I'm just trying to figure out how this can be done right and finding the free time to do it.