search

wrcad / xictools

XicTools: Xic graphical editor, WRspice circuit simulator, and accessories. for electronic design.
http://wrcad.com
138 stars 40 forks source link

(Re)enabled output of complex vectors in server mode (rawfile). #3

Closed markvolkmann closed 5 years ago

markvolkmann commented 5 years ago

Hi Steve,

Really enjoying becoming familiar with WRspice internals, thanks so much for open-sourcing this!

Something that we've noticed for some time is that in server mode, complex vectors as a result of .ac analyses are not output. Our old commercially procured version of WRspice had this property, so does the most recent version I tried.

I've made a change in fte/rawfile.cc to re-enable their output. It looks like their output was intended in the past (there's code that handles it), and maybe subsequently disabled, presumably intentionally.

What do you think, can we output complex vectors this way?

Kind regards, Mark

wrcad commented 5 years ago

This was a bug, the call to realvec() didn't used to be type-checked so was a test to see if the real or complex vector had data allocated or not. Thanks for the info and patch.

markvolkmann commented 5 years ago

Great, thanks!

On Wed, Oct 24, 2018 at 1:29 PM Stephen Whiteley notifications@github.com wrote:

This was a bug, the call to realvec() didn't used to be type-checked so was a test to see if the real or complex vector had data allocated or not. Thanks for the info and patch.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wrcad/xictools/pull/3#issuecomment-432816515, or mute the thread https://github.com/notifications/unsubscribe-auth/APOIGIZWmlM0yU5MJGhnm_tR2kbNteaRks5uoM28gaJpZM4X2ueE .