2.17.0 deployment [schools]

suzannezc commented 3 years ago

Prepare tracking

[x] Copy this task list to an issue labelled deployment
[x] Determine version number, assign it to this task list x.xx.x deployment [install(s)]

Adjust the code

[x] Prepare code changes
[x] Test changes in WPLabs
- [x] revise with client as needed until approved
- [x] screenshot testing events
- [x] screenshot errors and resolutions
[x] Test changes in schoolswrdsb
- [x] revise with client as needed until approved
- [x] screenshot testing events
- [x] screenshot errors and resolutions
[x] Git commit(s) all code including CHANGELOG.md and style.css version information
[x] Git push branch
[x] Pull request(s) to Production branch
[x] Tag Release, number and name are the same, details contain CHANGELOG.md details
[x] Delete branch

Initiate change process

[x] Submit Change Management Request
[x] add issue url to Description of CMR "Changes tracked in GitHub: URL"
[x] Add approval screenshots and PDF of email approval to Change Ticket
[x] record the number in a comment on this issue

Deploy the changes

[x] Update version through WordPress on all relevant installs

[x] schools.wrdsb.ca

Close change

[x] Add screenshots of successful change
[x] Add PDF of email approval from client
[x] Report change as successful
[x] Update task list with changes https://github.com/wrdsb/task-lists/blob/main/theme-update.txt
[x] Close this issue

suzannezc commented 3 years ago

CMR #2698

suzannezc commented 3 years ago

Discovered an issue as this is a single theme for all public installs, needs to work with corporate and schools etc at the same time (some header information was removed entirely instead of made conditional). Should be able to proceed with the change if this is fixed this week. @singhcwrdsb @rjduke

Adjusting the CMR to new version, these are the additional tasks:

Adjust the code

[x] Prepare code changes in https://github.com/wrdsb/wordpress-theme/tree/max-mega-menu-theme
- [x] conditional header based on if a corp site or other (all other public sites will be like the schools install)
- [x] menu theme globalization (functions.php)
- [x] wp-config changes if required
- [x] adjust style.css and CHANGELOG.md to 2.17.0 and add context
[x] Test changes in schoolswrdsb and wwwwrdsbdev and wp-training to ensure it works in production in both states
[x] update https://github.com/wrdsb/wordpress-static/tree/main/wp-config%20by%20install with any wp-config changes
[x] revise with client as needed until approved
[x] screenshot testing events
[x] screenshot errors and resolutions
[x] Git commit(s) all code including CHANGELOG.md and style.css version information
[x] Git push branch
[x] Pull request(s) to Production branch
[x] Tag Release, number and name are the same, details contain CHANGELOG.md details
[x] Delete branch
[x] update the Deploy changes section with any other actions that need to be taken when making this deployment (e.g., wp-config.php)

suzannezc commented 3 years ago

If the plugin isn't installed, the site will not load. Need to add a condition in the function to accommodate this. @singhcwrdsb

suzannezc commented 3 years ago

https://github.com/wrdsb/wordpress-theme/commit/bc8f6e85bbf902707014bb334ee17e0e71a157ff

wrdsb / wordpress-theme