v6.4.1 incompatible with IDEA 2024.2.EAP

wrdv / testme-idea

TestMe IntelliJ IDEA Plugin - Auto generates Unit Test code

http://weirddev.com/testme

Other

170 stars 63 forks source link

v6.4.1 incompatible with IDEA 2024.2.EAP #41

Closed yaronyam closed 2 weeks ago

yaronyam commented 4 months ago

following compilation issues of latest version against IDEA 2024.2 EAP:

Invocation of unresolved constructor DefaultTemplate.<init>(String, String, URL, URL) (2 problems)

Method FTFolderManager.loadDefaultsFromRoot() contains an invokespecial instruction referencing an unresolved constructor DefaultTemplate.<init>(String, String, URL, URL). This can lead to NoSuchMethodError exception at runtime.
Method FileTemplatesLoader.loadDefaultsFromRoot(...) contains an invokespecial instruction referencing an unresolved constructor DefaultTemplate.<init>(String, String, URL, URL). This can lead to NoSuchMethodError exception at runtime.

Invocation of unresolved method DefaultTemplate.getTemplateURL() (1 problem)

Method FTManager.createAndStoreBundledTemplate(...) contains an invokevirtual instruction referencing an unresolved method DefaultTemplate.getTemplateURL(). This can lead to NoSuchMethodError exception at runtime.

huangliang992 commented 1 month ago

Do we have a plan to Migrating from Gradle IntelliJ Plugin (1.x) to IntelliJ Platform Gradle Plugin (2.x), IDEA 2024.2+ Requires IntelliJ Platform Gradle Plugin (2.x)

yaronyam commented 1 month ago

@huangliang992 - correct. we need to migrate to IntelliJ Platform Gradle Plugin 2.x first. Regarding code changes, main issue is the need for backward compatibility with 2023.2 - 2024.1 versions, probably with reflection, if it's not too complicated. Thanks

yaronyam commented 3 weeks ago

@huangliang992 tested some scenarios...looks good 👍 few comments:

Shortcut for adding new template in Settings should be INSERT as before, rather then ENTER - it's aligned with behavior in other Setting forms where INSERT reflects Adding action. Furthermore, Enter is a problematic shortcut, when focus happens to moves away from the grid, it submits the Settings form. Relevant method call: addAction.registerCustomShortcutSet(
would be good if integrationTest can remain separated. its useful sometimes to run only test task and get fast UT feedback. if it's hard to achieve with the new intellij gradle plugin, then never mind for now.

there's some UT's failing - please see build log. default java file header is missing from generated test when running on IDEA 2023 - sample exception from build log:

2024-09-05T08:09:41.7845316Z TestMeGeneratorTestNgTest > testMockReturned FAILED
2024-09-05T08:09:41.7845724Z     com.intellij.testFramework.TestLoggerFactory$TestLoggerAssertionError: wrong number of arguments
2024-09-05T08:09:41.7846109Z         at com.intellij.testFramework.TestLoggerFactory$TestLogger.error(TestLoggerFactory.java:404)
2024-09-05T08:09:41.7846365Z         at com.intellij.openapi.diagnostic.Logger.error(Logger.java:436)
2024-09-05T08:09:41.7846900Z         at com.weirddev.testme.intellij.ui.template.FileTemplatesLoader.loadDefaultTemplates(FileTemplatesLoader.java:142)
2024-09-05T08:09:41.7847334Z         at com.weirddev.testme.intellij.ui.template.FileTemplatesLoader.<init>(FileTemplatesLoader.java:79)
2024-09-05T08:09:41.7847771Z         at com.weirddev.testme.intellij.ui.template.FileTemplateSettings.<init>(FileTemplateSettings.java:37)

Thanks!

huangliang992 commented 3 weeks ago

replaced CommonShortcuts.INSERT with CommonShortcuts.getInsert().
updated DefaultTemplate instance creation to meet multi constructors, it's the reason caused 'TestMeGeneratorTestNgTest > testMockReturned' UT failing.
"would be good if integrationTest can remain separated" i'm sorry for having no much time to finish this task recently

yaronyam commented 2 weeks ago

Support for IDEA 2024.2 developed by @huangliang992 in https://github.com/wrdv/testme-idea/pull/48 - released in v7.6.0