search

wreis / DBIx-Class-EncodedColumn

Automatically encode columns
https://metacpan.org/module/DBIx::Class::EncodedColumn
Other
2 stars 7 forks source link

Requires Math::Pari #1

Closed pdl closed 10 years ago

pdl commented 11 years ago

On my Strawberry Perl 5.12.3, Crypt::Random is installed but Math::Pari is not, and /t/open_pgp.t fails until Math::Pari is installed.

Crypt::OpenPGP uses Crypt::Random; Crypt::Random does not require Math::Pari, except when you ask Crypt::Random to do things it needs Math::Pari to do.

wreis commented 11 years ago

AFAICS, Crypt::Random requires Math::Pari since version 1.20 which was released in 2004 and now almost 10 years old. Thus, I am not sure if makes sense to add Math::Pari as direct dependency of DBIC::EncodedColumn, but instead should patch Crypt::OpenPGP about this issue as it directly (not only in specific scenarios) loads Math::Pari.

pdl commented 11 years ago

So in Makefile.PL would test_requires 'Crypt::Random' => 1.20; be the correct change?

wreis commented 11 years ago

Hmm...still not a direct dependency. IMO, we should patch Crypt::OpenPGP to set Crypt::Random-1.20 as minimal dep and then have another release of DBIC::EncodedColumn setting latest version of Crypt::OpenPGP as minimal dep.

danaj commented 10 years ago

It is also possible to patch Crypt::OpenPGP to completely remove Crypt::Random and Crypt::Primes. This will use only modules already distributed in Strawberry Perl 5.18.