search

wreis / DBIx-Class-EncodedColumn

Automatically encode columns
https://metacpan.org/module/DBIx::Class::EncodedColumn
Other
2 stars 7 forks source link

Test::Exception not listed as prerequisite #10

Closed perlpunk closed 5 years ago

perlpunk commented 5 years ago

t/crypt.t is using Test::Exception, but it's not listed in Makefile.PL or META.yml

t/crypt.t ................. Can't locate Test/Exception.pm in @INC
wreis commented 5 years ago

Good catch! Could you please send a PR?

perlpunk commented 5 years ago

done #11 :)

Also . is still missing in @INC (https://rt.cpan.org/Public/Bug/Display.html?id=121903)

Do you want a PR for that too?

wreis commented 5 years ago

Yeah, that is a feature in recent perl. If you could send a PR, I'd love to merge it!

perlpunk commented 5 years ago

btw, I found this issue because we at SUSE are building all CPAN packages in Open Build System (OBS): https://build.opensuse.org/package/show/devel:languages:perl:CPAN-D/perl-DBIx-Class-EncodedColumn Because the packages are built without the test depencendies from other modules, this kind of issue pops up more often than for regular testers. A link to OBS will probably be added soon to the testers matrix, so people can check build results there too.

perlpunk commented 5 years ago

Created #12

wreis commented 5 years ago

btw, I found this issue because we at SUSE are building all CPAN packages in Open Build System (OBS):

Very nice! Handy in order to improve CPAN packages. Thanks!

perlpunk commented 5 years ago

Hm, in the newest version it's in the Makefile.PL, but still not in META.yml.

I don't yet fully know our tool which reads the dependencies automatically, but it's not listing Test::Exception.

Another thing which could be improved: DBIx-Class-EncodedColumn-0.00017.tar.gz extracts to DBIx-Class-EncodedColumn/ instead of DBIx-Class-EncodedColumn-0.00017/.

I just fixed our tool to be able to deal with that, but it's in general a good idea that such a tarball extracts to a path with a version number.

Also there is a problem with Module::Install now: http://matrix.cpantesters.org/?dist=DBIx-Class-EncodedColumn+0.00017