search

wreis / DBIx-Class-EncodedColumn

Automatically encode columns
https://metacpan.org/module/DBIx::Class::EncodedColumn
Other
2 stars 7 forks source link

Make docs and code match #6

Closed perlpilot closed 7 years ago

perlpilot commented 7 years ago

The docs mention "encode_enable" when it should be "encode_column"

Also, the docs say "If this option is not set to true ..." but in reality the code checked specifically for the value 1 which is one of many true values, I opted for letting any true value work as the docs imply.

wreis commented 7 years ago

Thank you for the contribution.

However, I am wondering why you removed this part:

"If any one of these options is present the column will be treated as a digest column and all of the defaults will be applied to the rest of the options."

perlpilot commented 7 years ago

Ah, because it didn't seem to be true. The register_column sub requires that encode_column be present and true for it to even look at the other options.