search

wrf-model / WRF

The official repository for the Weather Research and Forecasting (WRF) model
Other
1.18k stars 657 forks source link

[Chem] Wrong unit or comment in chem/VPRM fluxes #1772

Open lpilz opened 1 year ago

lpilz commented 1 year ago

In the following line, either the unit conversion factor is too small by 3 orders of magnitude or the comment concerning the unit conversion is wrong.

mmol/m^2/s = 1e6 mmol/km^2/s = 1e3 mol/km^2/s = 3.6e6 mol/km^2/h

https://github.com/wrf-model/WRF/blob/f34b11dbb89c002c5c0dca1195aab35daeed7349/chem/module_ghg_fluxes.F#L131

weiwangncar commented 1 year ago

@jordanschnell Can you check? Thanks!

jordanschnell commented 1 year ago

@weiwangncar - Confirming with a frequent user of this module, will update

lpilz commented 1 year ago

@jordanschnell Just wanted to check back if there are any updates

michal-galkowski commented 2 months ago

Hi All, here the comment is wrong, the actual unit should be micro-mole m-2 s-1, as per reported in Mahadevan et al., 2008. I guess the original code developer was in haste, and since there are no Greek letters in Fortran...

See. Table 2.

https://agupubs.onlinelibrary.wiley.com/doi/10.1029/2006GB002735

lpilz commented 2 months ago

In that case, I would suggest changing this to ! For unit conversion from umol/m^2/s to mol/km2/hr