search

wrf-model / WRF

The official repository for the Weather Research and Forecasting (WRF) model
Other
1.18k stars 658 forks source link

Shared physics wsm6 #1993

Closed weiwangncar closed 5 months ago

weiwangncar commented 5 months ago

TYPE: enhancement, new feature

KEYWORDS: shared physics, WSM6

SOURCE: internal

DESCRIPTION OF CHANGES: Add WSM6 microphysics scheme from the shared physics directory, which is ccpp-compliant.

Solution: The CCPP-compliant WSM6 MP code will be residing in phys/physics_mmm/ directory. Currently it is a copy of the code from the future MMM-physics repo.

LIST OF MODIFIED FILES: M arch/postamble M arch/preamble M clean M main/depend.common M phys/Makefile M phys/module_microphysics_driver.F M phys/module_mp_wsm6.F M phys/module_physics_init.F A phys/physics_mmm/module_libmassv.F90 A phys/physics_mmm/mp_radar.F90 A phys/physics_mmm/mp_wsm6.F90 A phys/physics_mmm/mp_wsm6_effectRad.F90 M share/module_model_constants.F

TESTS CONDUCTED:

  1. The runs before and after this change produce bit-for-bit results when compiled with -d option.
  2. Are the Jenkins tests all passing?

RELEASE NOTE: Add WSM6 microphysics scheme from the future shared MMM-physics repository.

weiwangncar commented 5 months ago

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None
dudhia commented 5 months ago

Is it true that the effectRad has been reorganized to include the *_bg arrays as part of this?

On Thu, Feb 1, 2024 at 4:21 PM smileMchen @.***> wrote:

@.**** approved this pull request.

— Reply to this email directly, view it on GitHub https://github.com/wrf-model/WRF/pull/1993#pullrequestreview-1857888918, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIZ77CUDSEHM6264YDWRM3YRQPO7AVCNFSM6AAAAABCJWC4W6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNJXHA4DQOJRHA . You are receiving this because you were mentioned.Message ID: @.***>

weiwangncar commented 5 months ago

@dudhia I believe so: I see code 

 real(kind=kind_phys),intent(in):: re_qc_bg,re_qi_bg,re_qs_bg