Pxlsm lcz61 ii - Githubissues

coastwx commented 6 months ago

Pleim-Xiu LSM MODIS LCZ Compatibility & Surface Evaporation Update

TYPE: bug fix & physics refinement

KEYWORDS: MODIS, LCZ, P-X LSM, Latent Heat Flux

SOURCE: Robert Gilliam & Jon Pleim, US EPA

DESCRIPTION OF CHANGES: Problem:

User indicated that the P-X LSM errored for MODIS LCZ 61 NUM_LAND_CAT configuration.
Currently, we account for evaporation from transpiration, soil in both vegetated and non-veg parts, and wet leaves. But we only account for the latent heat effects on Tg from transpiration and evaporation from non-veg soil. This fix adds latent heat effects on Tg from soil in vegetated parts and from wet leaves.
Fix for rare case where GRDFLX goes NaN because of a divide by zero based on a soil parameter when a water cell turns to sea ice.

Solution: Logic checks in module_physics_init.F and module_sf_pxlsm.F were adjusted for 61 category inputs. P-X LSM data table, module_sf_pxlsm_data.F was updated for MODIS 61 categories. Default for LCZ 51-61 was set to MODIS urban class. We also added updates for the evaporation from vegetation and wet canopy.

ISSUE: Fixes: #1965

LIST OF MODIFIED FILES: M phys/module_physics_init.F M phys/module_sf_pxlsm.F M phys/module_sf_pxlsm_data.F

TESTS CONDUCTED:

Tested 61 class LCZ with PX LSM for a 1 day simulation with updated codes. Ran base MODIS 21 class scheme with same code before and after LCZ update. The results were identical after a 24 hour simulation. This confirms updates do not impact other MODIS settings in the P-X LSM. The MODIS 21 was by nature not identical to the MODIS 61, but similar enough and differences follow underlying differences in MODIS datasets.

Followed with another longer July 2018 test of the update surface evaporation in the P-X LSM.

The Jenkins tests are all passing.

RELEASE NOTE: Pleim-Xiu LSM is now compatible with 61 category MODIS LCZ landuse dataset. A mode of latent heat effects on Tg from vegetated parts and from wet leaves is added to Pleim-Xiu LSM.

weiwangncar commented 6 months ago

@coastwx Did you decide not to add RA, RS and LANDUSEF to the history output?

weiwangncar commented 6 months ago

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

coastwx commented 6 months ago

Thanks Wei. Looks like it passed the testing.

With the reservations of adding RA and RS and sensitivity to other user's default output size, I just left the registry out of the pull request. Also thought about LANDUSEF more. Since our domains are static, this can be used from other inputs. MCIP that processes WRF for CMAQ has an option to use the geogrid file for these geographical data inputs. RA and RS are different obviously, but sensitive to other users. We plan to update the P-X LSM run notes documentation with the other method of using text file to remove and add variables to the output. This is preferable anyhow because we can reduce the output size a lot. I'll pass along that updated document if NCAR is willing to replace the one hosted now.

weiwangncar commented 6 months ago

@coastwx That works with us. Thanks!

dudhia commented 6 months ago

Note that it would be OK to add h now that it is packaged as it only would appear in outputs when this option is selected.

On Wed, Mar 20, 2024 at 4:36 AM coastwx @.***> wrote:

Thanks Wei. Looks like it passed the testing.

With the reservations of adding RA and RS and sensitivity to other user's default output size, I just left the registry out of the pull request. Also thought about LANDUSEF more. Since our domains are static, this can be used from other inputs. MCIP that processes WRF for CMAQ has an option to use the geogrid file for these geographical data inputs. RA and RS are different obviously, but sensitive to other user's. We plan to update the P-X LSM run notes documentation with the other method of using text file to remove and add variables to the output. This is preferable anyhow because we can reduce the output size a lot.

— Reply to this email directly, view it on GitHub https://github.com/wrf-model/WRF/pull/2023#issuecomment-2009237990, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIZ77BVJNB4GHLLFZZDW5TYZFRA7AVCNFSM6AAAAABE5652HGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBZGIZTOOJZGA . You are receiving this because your review was requested.Message ID: @.***>

coastwx commented 6 months ago

This is great news. Now the packaged variables make more sense.

I’ll test and if appropriate I can do a simple pull request on that change.

Rob

From: dudhia @.> Sent: Wednesday, March 20, 2024 11:59 AM To: wrf-model/WRF @.> Cc: Gilliam, Robert @.>; Mention @.> Subject: Re: [wrf-model/WRF] Pxlsm lcz61 ii (PR #2023)

Caution: This email originated from outside EPA, please exercise additional caution when deciding whether to open attachments or click on provided links.

Note that it would be OK to add h now that it is packaged as it only would appear in outputs when this option is selected.

On Wed, Mar 20, 2024 at 4:36 AM coastwx @.<mailto:@.>> wrote:

Thanks Wei. Looks like it passed the testing.

With the reservations of adding RA and RS and sensitivity to other user's default output size, I just left the registry out of the pull request. Also thought about LANDUSEF more. Since our domains are static, this can be used from other inputs. MCIP that processes WRF for CMAQ has an option to use the geogrid file for these geographical data inputs. RA and RS are different obviously, but sensitive to other user's. We plan to update the P-X LSM run notes documentation with the other method of using text file to remove and add variables to the output. This is preferable anyhow because we can reduce the output size a lot.

— Reply to this email directly, view it on GitHub https://github.com/wrf-model/WRF/pull/2023#issuecomment-2009237990, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIZ77BVJNB4GHLLFZZDW5TYZFRA7AVCNFSM6AAAAABE5652HGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBZGIZTOOJZGA . You are receiving this because your review was requested.Message ID: @.<mailto:@.>>

— Reply to this email directly, view it on GitHubhttps://github.com/wrf-model/WRF/pull/2023#issuecomment-2009921991, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADVGWWHSVOCKDZIWZPQVAWTYZGW37AVCNFSM6AAAAABE5652HGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBZHEZDCOJZGE. You are receiving this because you were mentioned.Message ID: @.**@.>>

coastwx commented 5 months ago

Super. Thanks Wei and Jimy for the advice and consultation.

wrf-model / WRF

Pxlsm lcz61 ii #2023