search

wrf-model / WRF

The official repository for the Weather Research and Forecasting (WRF) model
Other
1.18k stars 658 forks source link

Final bug fixes and tuning of MYNN PBL for v4.6 #2037

Closed weiwangncar closed 2 months ago

weiwangncar commented 2 months ago

TYPE: bug fix + tuning

KEYWORDS: MYNN EDMF

SOURCE: Joseph Olson (NOAA-GSL)

DESCRIPTION OF CHANGES: Problems:

  1. overly diminished TKE in stable PBL - always dropping to the lower limit
  2. negative mass flux area fractions found (rarely) with activation criteria change from flt to fltv.
  3. edmf diagnostics erroneously included rho.

Solution:

  1. retuning of mixing lengths and stability function for momentum - mostly just limit changes.
  2. check for mf transfer of heat out of the lowest layer was modified
  3. removed rho.

LIST OF MODIFIED FILES: phys/module_bl_mynn.F

TESTS CONDUCTED:

  1. Tested in RRFSv1.
  2. The Jenkins tests are all passing.

This commit contains the final tuning of the MYNN for RRFSv1, and part of the update for 4.6 (together with PR-1938 and 1996).

weiwangncar commented 2 months ago

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None
weiwangncar commented 2 months ago

@dudhia @joeolson42 Can you review and approve this PR?

weiwangncar commented 2 months ago

@smileMchen Can you help approve this PR? Somehow Joe's approval wasn't counted....