search

wrf-model / WRF

The official repository for the Weather Research and Forecasting (WRF) model
Other
1.18k stars 658 forks source link

Stability function correction for momentum in mos subroutine of SLUCM. #2038

Open joshi994 opened 2 months ago

joshi994 commented 2 months ago

The first line should be a single-line "purpose" for this change

TYPE: Bug fix

KEYWORDS: Stability function, stability parameter, mos subroutine, Monin-Obukhov similarity theory, Urban canopy model, surface energy balance, Green roof temperature.

SOURCE: Parag Joshi (Brookhaven National Laboratory), Katia Lamer (Brookhaven National Laboratory)

DESCRIPTION OF CHANGES: Problem: The calculations for PSIM in the mos subroutine of module-sf_urban.F has been corrected. The earlier equations has a typo where X (= (1-16\zeta)^1/4) is mentioned instead of X0. In addition, following the formulation of surface energy balance of OSU1DPBL scheme by Ek and Mahrt 1991, it appears that when the following definition is used $\sigma * \theta_s^4 = \sigma T_0^4 (1 + 4((\theta_s - T_0)/T_0)))$ is used, the temperature in the calculations of net flux at the surface should use T_0 (temperature at first atmospheric level). However, in the module TGRP (temperature of the green roof surface at previous time step is used)is used instead of T_0 (please refer to the attached screenshots of the formulation).

Also I am not sure why the term (\theta_0 - T_0) is neglected in the definition of YY (Line/command 1145 WRFv-4.5.2) whereas the equation for the $\theta_s$ in attached screenshot shows the term. Due to insignficant impact?

Solution: Following the formulation, the temperature variable has been updated according. Moreover, the mos subroutine is also corrected by replacing X by X0 where X0 is =X*z0/(z+z0) (as per the WRF/phys/module_sf_urban.F).

ISSUE: For use when this PR closes an issue. Fixes #123

LIST OF MODIFIED FILES: module_sf_urban.F

TESTS CONDUCTED:

  1. A test case could be run to compare the impact of changes in the TGR and stability parameter value as well as CD, US, and ALPHA.

For more details, refer to the pages # 47-50 of the document link in the release note.

RELEASE NOTE: The surface energy balance for the green roof is modified following the OSU1DPBL scheme. The document can be located at:
[https://ftp.emc.ncep.noaa.gov/mmb/gcp/ldas/nceplsm/OSU1DPBL/OSU1DPBL-userguide.pdf]

Screenshot 2024-04-17 at 2 20 50 PM Screenshot 2024-04-17 at 2 38 26 PM

]

weiwangncar commented 2 months ago

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None
cenlinhe commented 2 months ago

I am also bringing @barlage here just in case he has any insights on this problem.