search

wrf-model / WRF

The official repository for the Weather Research and Forecasting (WRF) model
Other
1.24k stars 677 forks source link

Release v4.5.1 #2052

Open tliartsi opened 4 months ago

tliartsi commented 4 months ago

The first line should be a single-line "purpose" for this change

TYPE: choose one of [bug fix, enhancement, new feature, feature removed, no impact, text only]

KEYWORDS: 5 to 10 words related to commit, separated by commas

SOURCE: Either "developer's name (affiliation)" .XOR. "internal" for a WRF Dev committee member

DESCRIPTION OF CHANGES: Problem: Generally or specifically, what was wrong and needed to be addressed?

Solution: What was down algorithmically and in the source code to address the problem?

ISSUE: For use when this PR closes an issue. Fixes #123

LIST OF MODIFIED FILES: list of changed files (use git diff --name-status master to get formatted list)

TESTS CONDUCTED:

  1. Do mods fix problem? How can that be demonstrated, and was that test conducted?
  2. Are the Jenkins tests all passing?

RELEASE NOTE: Include a stand-alone message suitable for the inclusion in the minor and annual releases. A publication citation is appropriate.

weiwangncar commented 4 months ago

@tliartsi Please make PR using the latest release of the model - right now that version is 4.6.0. We do not make changes to previously released code. Also please edit the PR message (top box) to describe what you would like to change and reason for the change.

dudhia commented 4 months ago

The scale of this change implies it is a new scheme and should target the develop branch.

weiwangncar commented 4 months ago

@tliartsi It looks like your PR can be updated with respect to our develop branch (which is the same as 4.6.0 branch at this time). Please edit the PR message as suggested before.

dudhia commented 4 months ago

@tliartsi Note that we are still waiting for a description of this method. Is it a new option or addition to an existing option. Also note that there are conflicts with the existing up-to-date code. We need all this resolved before we can start considering it.