search

wrf-model / WRF

The official repository for the Weather Research and Forecasting (WRF) model
Other
1.25k stars 689 forks source link

module_big_step_utilities_em.F - logical variable "specified" not assigned #895

Closed rozumal closed 5 years ago

rozumal commented 5 years ago

WRF V4.1:

In subroutine sixth_order_diffusion, the logical variable "specified" not assigned a value before being used, resulting in a crash on my system.

Changed to (line 6300):

! Should be initialized! specified = .false. if(config_flags%specified .or. config_flags%nested) specified = .true.

diff_6th_coef = diff_6th_factor * 0.015625 / ( 2.0 * dt )
weiwangncar commented 5 years ago

Thank you for pointing this out. We will fix this in the next release.

On Tue, May 7, 2019 at 12:33 PM rozumal notifications@github.com wrote:

WRF V4.1:

In subroutine sixth_order_diffusion, the logical variable "specified" not assigned a value before being used, resulting in a crash on my system.

Changed to (line 6300):

! Should be initialized!

specified = .false. if(config_flags%specified .or. config_flags%nested) specified = .true.

diff_6th_coef = diff_6th_factor 0.015625 / ( 2.0 dt )

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/wrf-model/WRF/issues/895, or mute the thread https://github.com/notifications/unsubscribe-auth/ADA57EFF4MZS5CS7VGF246TPUHDRHANCNFSM4HLLNO6A .

rozumal commented 5 years ago

You might want to issue a "fix" since it can cause serious problems with simulations.

Thanks

Robert

On Tue, May 7, 2019 at 1:11 PM weiwangncar notifications@github.com wrote:

Thank you for pointing this out. We will fix this in the next release.

On Tue, May 7, 2019 at 12:33 PM rozumal notifications@github.com wrote:

WRF V4.1:

In subroutine sixth_order_diffusion, the logical variable "specified" not assigned a value before being used, resulting in a crash on my system.

Changed to (line 6300):

! Should be initialized!

specified = .false. if(config_flags%specified .or. config_flags%nested) specified = .true.

diff_6th_coef = diff_6th_factor 0.015625 / ( 2.0 dt )

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/wrf-model/WRF/issues/895, or mute the thread < https://github.com/notifications/unsubscribe-auth/ADA57EFF4MZS5CS7VGF246TPUHDRHANCNFSM4HLLNO6A

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wrf-model/WRF/issues/895#issuecomment-490218009, or mute the thread https://github.com/notifications/unsubscribe-auth/AMALR7SNRUXMGY6RCKVWMODPUHH77ANCNFSM4HLLNO6A .

--

Robert A. Rozumalski, PhD NWS National SOO Science and Training Resource Coordinator NOAA/NWS/FDTD - Forecast Decision Training Division COMET/UCAR PO Box 3000 Boulder, CO 80307-3000 Phone: 303.497.8356

weiwangncar commented 5 years ago

We will. What is the compiler you use in this case?

On Tue, May 7, 2019 at 1:19 PM rozumal notifications@github.com wrote:

You might want to issue a "fix" since it can cause serious problems with simulations.

Thanks

Robert

On Tue, May 7, 2019 at 1:11 PM weiwangncar notifications@github.com wrote:

Thank you for pointing this out. We will fix this in the next release.

On Tue, May 7, 2019 at 12:33 PM rozumal notifications@github.com wrote:

WRF V4.1:

In subroutine sixth_order_diffusion, the logical variable "specified" not assigned a value before being used, resulting in a crash on my system.

Changed to (line 6300):

! Should be initialized!

specified = .false. if(config_flags%specified .or. config_flags%nested) specified = .true.

diff_6th_coef = diff_6th_factor 0.015625 / ( 2.0 dt )

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/wrf-model/WRF/issues/895, or mute the thread <

https://github.com/notifications/unsubscribe-auth/ADA57EFF4MZS5CS7VGF246TPUHDRHANCNFSM4HLLNO6A

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wrf-model/WRF/issues/895#issuecomment-490218009, or mute the thread < https://github.com/notifications/unsubscribe-auth/AMALR7SNRUXMGY6RCKVWMODPUHH77ANCNFSM4HLLNO6A

.

--

Robert A. Rozumalski, PhD NWS National SOO Science and Training Resource Coordinator NOAA/NWS/FDTD - Forecast Decision Training Division COMET/UCAR PO Box 3000 Boulder, CO 80307-3000 Phone: 303.497.8356

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/wrf-model/WRF/issues/895#issuecomment-490220486, or mute the thread https://github.com/notifications/unsubscribe-auth/ADA57EEMZBGXP57OQKRQ7O3PUHI3VANCNFSM4HLLNO6A .

rozumal commented 5 years ago

Hello,

My Pgi & Intel compilers are part of the shared UCAR licenses

I get the crash when compiled with Intel 18.0.1, within a few timesteps (seg fault)

I get the pre-run check error about "specified" not being assigned a value when I compile after "configure -D" (Intel 18.0.1)

When compiled with Pgi, no error is detected when compiled for debugging, and the simulation runs to completion. Same when Pgi compiled without debugging on.

So Pgi must assign an acceptable T|F value to the variable at run-time or its just luck. I'll go with luck.

Bob

On Tue, May 7, 2019 at 3:59 PM weiwangncar notifications@github.com wrote:

We will. What is the compiler you use in this case?

On Tue, May 7, 2019 at 1:19 PM rozumal notifications@github.com wrote:

You might want to issue a "fix" since it can cause serious problems with simulations.

Thanks

Robert

On Tue, May 7, 2019 at 1:11 PM weiwangncar notifications@github.com wrote:

Thank you for pointing this out. We will fix this in the next release.

On Tue, May 7, 2019 at 12:33 PM rozumal notifications@github.com wrote:

WRF V4.1:

In subroutine sixth_order_diffusion, the logical variable "specified" not assigned a value before being used, resulting in a crash on my system.

Changed to (line 6300):

! Should be initialized!

specified = .false. if(config_flags%specified .or. config_flags%nested) specified = .true.

diff_6th_coef = diff_6th_factor 0.015625 / ( 2.0 dt )

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/wrf-model/WRF/issues/895, or mute the thread <

https://github.com/notifications/unsubscribe-auth/ADA57EFF4MZS5CS7VGF246TPUHDRHANCNFSM4HLLNO6A

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wrf-model/WRF/issues/895#issuecomment-490218009, or mute the thread <

https://github.com/notifications/unsubscribe-auth/AMALR7SNRUXMGY6RCKVWMODPUHH77ANCNFSM4HLLNO6A

.

--

Robert A. Rozumalski, PhD NWS National SOO Science and Training Resource Coordinator NOAA/NWS/FDTD - Forecast Decision Training Division COMET/UCAR PO Box 3000 Boulder, CO 80307-3000 Phone: 303.497.8356

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/wrf-model/WRF/issues/895#issuecomment-490220486, or mute the thread < https://github.com/notifications/unsubscribe-auth/ADA57EEMZBGXP57OQKRQ7O3PUHI3VANCNFSM4HLLNO6A

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wrf-model/WRF/issues/895#issuecomment-490270552, or mute the thread https://github.com/notifications/unsubscribe-auth/AMALR7RBKBHOXYA5LIK5D7LPUH3THANCNFSM4HLLNO6A .

--

Robert A. Rozumalski, PhD NWS National SOO Science and Training Resource Coordinator NOAA/NWS/FDTD - Forecast Decision Training Division COMET/UCAR PO Box 3000 Boulder, CO 80307-3000 Phone: 303.497.8356

weiwangncar commented 5 years ago

I tested with Intel 17.0.1, and it didn't complain, and the model didn't fail and produced expected results.

On Tue, May 7, 2019 at 4:19 PM rozumal notifications@github.com wrote:

Hello,

My Pgi & Intel compilers are part of the shared UCAR licenses

I get the crash when compiled with Intel 18.0.1, within a few timesteps (seg fault)

I get the pre-run check error about "specified" not being assigned a value when I compile after "configure -D" (Intel 18.0.1)

When compiled with Pgi, no error is detected when compiled for debugging, and the simulation runs to completion. Same when Pgi compiled without debugging on.

So Pgi must assign an acceptable T|F value to the variable at run-time or its just luck. I'll go with luck.

Bob

On Tue, May 7, 2019 at 3:59 PM weiwangncar notifications@github.com wrote:

We will. What is the compiler you use in this case?

On Tue, May 7, 2019 at 1:19 PM rozumal notifications@github.com wrote:

You might want to issue a "fix" since it can cause serious problems with simulations.

Thanks

Robert

On Tue, May 7, 2019 at 1:11 PM weiwangncar notifications@github.com wrote:

Thank you for pointing this out. We will fix this in the next release.

On Tue, May 7, 2019 at 12:33 PM rozumal notifications@github.com wrote:

WRF V4.1:

In subroutine sixth_order_diffusion, the logical variable "specified" not assigned a value before being used, resulting in a crash on my system.

Changed to (line 6300):

! Should be initialized!

specified = .false. if(config_flags%specified .or. config_flags%nested) specified = .true.

diff_6th_coef = diff_6th_factor 0.015625 / ( 2.0 dt )

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/wrf-model/WRF/issues/895, or mute the thread <

https://github.com/notifications/unsubscribe-auth/ADA57EFF4MZS5CS7VGF246TPUHDRHANCNFSM4HLLNO6A

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/wrf-model/WRF/issues/895#issuecomment-490218009 , or mute the thread <

https://github.com/notifications/unsubscribe-auth/AMALR7SNRUXMGY6RCKVWMODPUHH77ANCNFSM4HLLNO6A

.

--

Robert A. Rozumalski, PhD NWS National SOO Science and Training Resource Coordinator NOAA/NWS/FDTD - Forecast Decision Training Division COMET/UCAR PO Box 3000 Boulder, CO 80307-3000 Phone: 303.497.8356

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/wrf-model/WRF/issues/895#issuecomment-490220486, or mute the thread <

https://github.com/notifications/unsubscribe-auth/ADA57EEMZBGXP57OQKRQ7O3PUHI3VANCNFSM4HLLNO6A

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wrf-model/WRF/issues/895#issuecomment-490270552, or mute the thread < https://github.com/notifications/unsubscribe-auth/AMALR7RBKBHOXYA5LIK5D7LPUH3THANCNFSM4HLLNO6A

.

--

Robert A. Rozumalski, PhD NWS National SOO Science and Training Resource Coordinator NOAA/NWS/FDTD - Forecast Decision Training Division COMET/UCAR PO Box 3000 Boulder, CO 80307-3000 Phone: 303.497.8356

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/wrf-model/WRF/issues/895#issuecomment-490275665, or mute the thread https://github.com/notifications/unsubscribe-auth/ADA57EGRNTQ25QGEK3344JTPUH6ALANCNFSM4HLLNO6A .

rozumal commented 5 years ago

Good morning,

It's going to be system/compiler dependent. Since no value is being assigned before being used, it's going to use whatever value happens to be in memory when the subroutine is called. In my case, it was the wrong value given the configuration, which was a single 6km domain (250 x 250) over the US, i.e nothing special.

I don't know why the Intel compiler failed to catch the unassigned variable. It clearly has no set value when used. I configured with "configure -D."

Thanks

Robert

On Tue, May 7, 2019 at 4:28 PM weiwangncar notifications@github.com wrote:

I tested with Intel 17.0.1, and it didn't complain, and the model didn't fail and produced expected results.

On Tue, May 7, 2019 at 4:19 PM rozumal notifications@github.com wrote:

Hello,

My Pgi & Intel compilers are part of the shared UCAR licenses

I get the crash when compiled with Intel 18.0.1, within a few timesteps (seg fault)

I get the pre-run check error about "specified" not being assigned a value when I compile after "configure -D" (Intel 18.0.1)

When compiled with Pgi, no error is detected when compiled for debugging, and the simulation runs to completion. Same when Pgi compiled without debugging on.

So Pgi must assign an acceptable T|F value to the variable at run-time or its just luck. I'll go with luck.

Bob

On Tue, May 7, 2019 at 3:59 PM weiwangncar notifications@github.com wrote:

We will. What is the compiler you use in this case?

On Tue, May 7, 2019 at 1:19 PM rozumal notifications@github.com wrote:

You might want to issue a "fix" since it can cause serious problems with simulations.

Thanks

Robert

On Tue, May 7, 2019 at 1:11 PM weiwangncar <notifications@github.com

wrote:

Thank you for pointing this out. We will fix this in the next release.

On Tue, May 7, 2019 at 12:33 PM rozumal notifications@github.com wrote:

WRF V4.1:

In subroutine sixth_order_diffusion, the logical variable "specified" not assigned a value before being used, resulting in a crash on my system.

Changed to (line 6300):

! Should be initialized!

specified = .false. if(config_flags%specified .or. config_flags%nested) specified = .true.

diff_6th_coef = diff_6th_factor 0.015625 / ( 2.0 dt )

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/wrf-model/WRF/issues/895, or mute the thread <

https://github.com/notifications/unsubscribe-auth/ADA57EFF4MZS5CS7VGF246TPUHDRHANCNFSM4HLLNO6A

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/wrf-model/WRF/issues/895#issuecomment-490218009 , or mute the thread <

https://github.com/notifications/unsubscribe-auth/AMALR7SNRUXMGY6RCKVWMODPUHH77ANCNFSM4HLLNO6A

.

--

Robert A. Rozumalski, PhD NWS National SOO Science and Training Resource Coordinator NOAA/NWS/FDTD - Forecast Decision Training Division COMET/UCAR PO Box 3000 Boulder, CO 80307-3000 Phone: 303.497.8356

— You are receiving this because you commented. Reply to this email directly, view it on GitHub <https://github.com/wrf-model/WRF/issues/895#issuecomment-490220486 , or mute the thread <

https://github.com/notifications/unsubscribe-auth/ADA57EEMZBGXP57OQKRQ7O3PUHI3VANCNFSM4HLLNO6A

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wrf-model/WRF/issues/895#issuecomment-490270552, or mute the thread <

https://github.com/notifications/unsubscribe-auth/AMALR7RBKBHOXYA5LIK5D7LPUH3THANCNFSM4HLLNO6A

.

--

Robert A. Rozumalski, PhD NWS National SOO Science and Training Resource Coordinator NOAA/NWS/FDTD - Forecast Decision Training Division COMET/UCAR PO Box 3000 Boulder, CO 80307-3000 Phone: 303.497.8356

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/wrf-model/WRF/issues/895#issuecomment-490275665, or mute the thread < https://github.com/notifications/unsubscribe-auth/ADA57EGRNTQ25QGEK3344JTPUH6ALANCNFSM4HLLNO6A

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wrf-model/WRF/issues/895#issuecomment-490277652, or mute the thread https://github.com/notifications/unsubscribe-auth/AMALR7QC6ZCIA4V2JNDUQPLPUH67HANCNFSM4HLLNO6A .

--

Robert A. Rozumalski, PhD NWS National SOO Science and Training Resource Coordinator NOAA/NWS/FDTD - Forecast Decision Training Division COMET/UCAR PO Box 3000 Boulder, CO 80307-3000 Phone: 303.497.8356

weiwangncar commented 5 years ago

Fix added to 4.1.1, and will be posted to Known Problem.

dudhia commented 5 years ago

We have a Known Problem label that could be attached to this type of PR.

On Thu, May 9, 2019 at 12:23 PM weiwangncar notifications@github.com wrote:

Fix added to 4.1.1, and will be posted to Known Problem.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/wrf-model/WRF/issues/895#issuecomment-491013725, or mute the thread https://github.com/notifications/unsubscribe-auth/AEIZ77A5FAFA43B7W6HN76LPURT3VANCNFSM4HLLNO6A .