wrfly / container-web-tty

Connect your containers via a web-tty
https://container-web-tty.kfd.me/
Apache License 2.0
245 stars 45 forks source link

fixed TrimLeft usage to TrimPrefix for us to not miss characters #50

Closed itzikban closed 4 years ago

itzikban commented 4 years ago

Hi Guys,

Found an issue in Kubernetes connector that affects enumerated containers. I used TrimPrefix instead of TrimLeft function because TrimLeft has removed in some cases characters in ContainerID hash.

Here is a simple example that showcases the reason for the change: https://play.golang.org/p/B2FD7C4rpuW

wrfly commented 4 years ago

@itzikban thanks!