search

wri / UrbanLandUse

Characterizing urban land use with machine learning
29 stars 10 forks source link

conda migration #4

Closed pkerins closed 5 years ago

pkerins commented 5 years ago

We are now using a conda environment to manage our Python packages, whereas before we were installing things with pip. As a result, some imports no longer work as expected (eg import keras) and need to be replaced. Additionally, code referencing the original imports may also no longer be able to execute (eg network = K.load_model(network_filename, custom_objects={'loss': 'categorical-crossentropy'})). Both pieces need to be corrected, whether in util files or notebooks.

Taufiq06 commented 5 years ago

I checked all the util files in the branch: upgrade/py3. Looks like all the import statements are already updated there for conda migration. The next thing would be to check the notebooks and make sure everything is updated there as well.

pkerins commented 5 years ago

One thing to monitor is whether the util import statements within the other util files will still work. I believe so, but you may remember the issue from last week with pathing and import util_xxx vs import utils.util_xxx. That was an issue in the notebooks rather than the util files themselves, but something to keep in mind. As with some of these other issues, we can close it once we confirm successful use of these util files within updated workflow notebooks.