wri / gfw-raster-analysis-lambda

GFW Raster Analysis in AWS Lambda
8 stars 4 forks source link

save results in chunks of dynamodb batch write limit #58

Closed solomon-negusse closed 2 years ago

solomon-negusse commented 2 years ago

This was reviewed when it got merged to develop branch but decided to push it to master as hotfix since develop has other changes that'll need more time for testing before going to production.

Pull request checklist

Please check if your PR fulfills the following requirements:

Pull request type

Please check the type of change your PR introduces: - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior?

Storing results in dynamodb fails when results list size exceeds batch_write_item limit of 25 items Issue Number: GTC-1428

What is the new behavior?

Does this introduce a breaking change?

Other information

codecov[bot] commented 2 years ago

Codecov Report

Merging #58 (273c96e) into master (7cfa0ef) will increase coverage by 0.08%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   91.69%   91.78%   +0.08%     
==========================================
  Files          20       20              
  Lines        1156     1168      +12     
==========================================
+ Hits         1060     1072      +12     
  Misses         96       96              
Flag Coverage Δ
unittests 91.78% <100.00%> (+0.08%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/e2e/test_raster_analysis.py 100.00% <ø> (ø)
raster_analysis/globals.py 100.00% <100.00%> (ø)
raster_analysis/results_store.py 94.28% <100.00%> (+0.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7cfa0ef...273c96e. Read the comment docs.