Respect null NoData values - Githubissues

wri / gfw-raster-analysis-lambda

GFW Raster Analysis in AWS Lambda

8 stars 4 forks source link

Respect null NoData values #64

Closed jterry64 closed 1 year ago

jterry64 commented 1 year ago

One thing we missed was that layers can have null NoData values, indicating all values should be treated as data.

Pull request checklist

Please check if your PR fulfills the following requirements:

[X] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
[X] Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
[X] Check the commit's or even all commits' message styles matches our requested structure.
[X] Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

[X] Bugfix
[X] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

null NoData values cause a parsing error, since NoData has to be either an integer or NaN.

What is the new behavior?

null NoData values will be accepted
processes for masking NoData values will be skipped for layers with null NoData

Does this introduce a breaking change?

[ ] Yes
[X] No