This is a corner case where a large and complicated geometry had one tile intersection become an empty polygon after making it valid (it probably created a thin sliver). The code path for handling this corner case was invalid.
Pull request checklist
Please check if your PR fulfills the following requirements:
[X] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
[X] Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
[X] Check the commit's or even all commits' message styles matches our requested structure.
[X] Check your code additions will fail neither code linting checks nor unit test.
Pull request type
Please check the type of change your PR introduces:
[X] Bugfix
[] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):
What is the current behavior?
On getting an empty polygon intersection, the lambdas tries to return an empty dictionary instead of an empty pandas DataFrame as the result. This causes an exception on saving the result to DynamoDB when it tries get its shape.
Issue Number: GTC-2458
What is the new behavior?
Return an empty pandas DataFrame in this case.
Remove an unnecessary line of code that wasn't actually ever working.
The pre-commit hooks picked up some formatting changes.
This is a corner case where a large and complicated geometry had one tile intersection become an empty polygon after making it valid (it probably created a thin sliver). The code path for handling this corner case was invalid.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
On getting an empty polygon intersection, the lambdas tries to return an empty dictionary instead of an empty pandas DataFrame as the result. This causes an exception on saving the result to DynamoDB when it tries get its shape.
Issue Number: GTC-2458
What is the new behavior?
Does this introduce a breaking change?