wri / gfw_forest_loss_geotrellis

Global Tree Cover Loss Analysis using Geotrellis and SPARK
MIT License
10 stars 8 forks source link

use conf file to source FCD layers based on feature flag #109

Closed echeipesh closed 3 years ago

echeipesh commented 3 years ago

Pull request checklist

Pull request type

Please check the type of change your PR introduces:

What is the current behavior?

Currently the layers are hard-coded with URIs for their tiles, which is great. A new nice-to-have is to be able to source two different versions of rasters for flagship and pro instances of this app so that data verification and integration can happen on their own independent schedules.

What is the new behavior?

This PR adds the ability specify raster sources in the config files, which can be switched using the --gfwpro flag. Each source MAY use the config to get the URI template or it can continue hard-coding its URI. This PR updates the layers required for FCD analysis because this is where the current need to maintain two versions exists.

The versions of for the PRO are pulled from "Before" state of https://github.com/wri/gfw_forest_loss_geotrellis/pull/103 because that was the last check-point for verification and UI integration.

Does this introduce a breaking change?

Hard to say, may likes like the TreeCoverDensity layer and IntactForestLandscape were sourcing inconsistent versions for different version of filtered tiles. Its hard to say what analysis it would effect and I won't, but it may, so now you know.