search

wri / gfw_forest_loss_geotrellis

Global Tree Cover Loss Analysis using Geotrellis and SPARK
MIT License
10 stars 8 forks source link

GFW_FEATURE_FLAG #110

Closed echeipesh closed 3 years ago

echeipesh commented 3 years ago
## Pull request type Please check the type of change your PR introduces: - [x] Bugfix - [x] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior? currently we're using `--gfwpro` flag to control which rasters get read for Pro and which tags we're using. The mechanism used however does not work on EMR because Spark does not properly serialize the state of the global variable and ends up running with default value `flagship`. Making the current mechanism work would require a pretty large refactor so the next best is the ENV variable. ## What is the new behavior? Using `GFW_FEATURE_FLAG` = `pro`, `flagship`, or null with `pro` being default behavior. ## Does this introduce a breaking change? - [x] Yes - [ ] No for the moment pro is the default configuration, this may not be desirable in the long-run, but either way this now needs to be considered by flagship run or changed on further discussion.